chrome/test/live_sync/single_client_live_passwords_sync_test.cc - Issue 6462015: Cleanup more test code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/live_sync/single_client_live_passwords_sync_test.cc

Issue 6462015: Cleanup more test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: wtf windows is this me Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/test/live_sync/single_client_live_extensions_sync_test.cc ('k') | chrome/test/live_sync/single_client_live_preferences_sync_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/password_manager/password_form_data.h"	5 #include "chrome/browser/password_manager/password_form_data.h"

	6 #include "chrome/browser/sync/profile_sync_service_harness.h"

6 #include "chrome/test/live_sync/live_passwords_sync_test.h"	7 #include "chrome/test/live_sync/live_passwords_sync_test.h"

7	8

8 using webkit_glue::PasswordForm;	9 using webkit_glue::PasswordForm;

9	10

10 // TODO(sync): Remove FAILS_ annotation after http://crbug.com/59867 is fixed.	11 // TODO(sync): Remove FAILS_ annotation after http://crbug.com/59867 is fixed.

11 #if defined(OS_MACOSX)	12 #if defined(OS_MACOSX)

12 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, FAILS_Sanity) {	13 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, FAILS_Sanity) {

13 #else	14 #else

14 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, Sanity) {	15 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, Sanity) {

15 #endif	16 #endif

(...skipping 11 matching lines...) Expand all Loading...
27 "Waiting for passwords change."));	28 "Waiting for passwords change."));

28	29

29 std::vector<PasswordForm> expected;	30 std::vector<PasswordForm> expected;

30 GetLogins(GetVerifierPasswordStore(), form, expected);	31 GetLogins(GetVerifierPasswordStore(), form, expected);

31 ASSERT_EQ(1U, expected.size());	32 ASSERT_EQ(1U, expected.size());

32	33

33 std::vector<PasswordForm> actual;	34 std::vector<PasswordForm> actual;

34 GetLogins(GetPasswordStore(0), form, actual);	35 GetLogins(GetPasswordStore(0), form, actual);

35 ASSERT_TRUE(ContainsSamePasswordForms(expected, actual));	36 ASSERT_TRUE(ContainsSamePasswordForms(expected, actual));

36 }	37 }

OLD	NEW