Make sure that we do not call is_extensible on the global proxy....

Make sure that we do not call is_extensible on the global proxy.

When calling Object.isExtensible we did not do a check for the global
js proxy. This caused the check on the extensible bit on the map to
return true, even when the bit was set to false on the global js
object.



Committed: http://code.google.com/p/v8/source/detail?r=6677

[Mads Ager (chromium), 2011-02-08 13:04:22]

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
src/runtime.cc:881: static MaybeObject* Runtime_PreventExtensions(Arguments
args) {
Do you need it here too?

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode892
src/runtime.cc:892: if (proto->IsNull()) return obj;
Return false? Otherwise this will be interpreted as true.

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode896
src/runtime.cc:896: return obj->map()->is_extensible() ?  Heap::true_value()
Remove extra space.

[Mads Ager (chromium), 2011-02-08 13:04:34]

And LGTM with that fixed.

On 2011/02/08 13:04:22, Mads Ager wrote:
> http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
> src/runtime.cc:881: static MaybeObject* Runtime_PreventExtensions(Arguments
> args) {
> Do you need it here too?
> 
> http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode892
> src/runtime.cc:892: if (proto->IsNull()) return obj;
> Return false? Otherwise this will be interpreted as true.
> 
> http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode896
> src/runtime.cc:896: return obj->map()->is_extensible() ?  Heap::true_value()
> Remove extra space.

[Rico, 2011-02-08 13:08:58]

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
src/runtime.cc:881: static MaybeObject* Runtime_PreventExtensions(Arguments
args) {
On 2011/02/08 13:04:22, Mads Ager wrote:
> Do you need it here too?
No, we do this in PreventExtensions in objects.cc

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode892
src/runtime.cc:892: if (proto->IsNull()) return obj;
On 2011/02/08 13:04:22, Mads Ager wrote:
> Return false? Otherwise this will be interpreted as true.

Done.

http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode896
src/runtime.cc:896: return obj->map()->is_extensible() ?  Heap::true_value()
On 2011/02/08 13:04:22, Mads Ager wrote:
> Remove extra space.

Done.