Make sure that we do not call is_extensible on the global proxy....

src/runtime.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 860 matching lines @@
     { MaybeObject* maybe_value = obj->GetProperty(*obj, &result, *name, &attrs);
       if (!maybe_value->ToObject(&value)) return maybe_value;
     }
     elms->set(VALUE_INDEX, value);
   }
 
   return *desc;
 }
 
 
 static MaybeObject* Runtime_PreventExtensions(Arguments args) {

[Mads Ager (chromium), 2011/02/08 13:04:22]

Do you need it here too?

[Rico, 2011/02/08 13:08:58]

No, we do this in PreventExtensions in objects.cc

   ASSERT(args.length() == 1);
   CONVERT_CHECKED(JSObject, obj, args[0]);
   return obj->PreventExtensions();
 }
 
 static MaybeObject* Runtime_IsExtensible(Arguments args) {
   ASSERT(args.length() == 1);
   CONVERT_CHECKED(JSObject, obj, args[0]);
+  if (obj->IsJSGlobalProxy()) {
+    Object* proto = obj->GetPrototype();
+    if (proto->IsNull()) return obj;

[Mads Ager (chromium), 2011/02/08 13:04:22]

Return false? Otherwise this will be interpreted as true.

[Rico, 2011/02/08 13:08:58]

Done.

+    ASSERT(proto->IsJSGlobalObject());
+    obj = JSObject::cast(proto);
+  }
   return obj->map()->is_extensible() ?  Heap::true_value()

[Mads Ager (chromium), 2011/02/08 13:04:22]

Remove extra space.

[Rico, 2011/02/08 13:08:58]

Done.

                                      : Heap::false_value();
 }
 
 
 static MaybeObject* Runtime_RegExpCompile(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 3);
   CONVERT_ARG_CHECKED(JSRegExp, re, 0);
   CONVERT_ARG_CHECKED(String, pattern, 1);
   CONVERT_ARG_CHECKED(String, flags, 2);
@@ skipping 10166 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     Counters::gc_last_resort_from_js.Increment();
     Heap::CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal