Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 6445: This change removes the %AddProperty native JavaScript function from V8.... (Closed)

Created:
12 years, 2 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

This change removes the %AddProperty native JavaScript function from V8. All uses of %AddProperty are replaced by %SetProperty. A few uses of IgnoreAttributesAndSetLocalProperty are added, and the runtime version of it adds a PropertyAttributes argument. Only the JSObject class in objects.cc now uses AddProperty, and it can become private. Committed: http://code.google.com/p/v8/source/detail?r=426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -94 lines) Patch
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date-delay.js View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +33 lines, -9 lines 0 comments Download
M src/messages.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/regexp-delay.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime.cc View 5 chunks +25 lines, -25 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 16 chunks +64 lines, -41 lines 0 comments Download
M test/mjsunit/regress/regress-1199637.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
12 years, 2 months ago (2008-10-03 11:57:56 UTC) #1
Mads Ager (chromium)
12 years, 2 months ago (2008-10-03 12:02:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698