Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: src/messages.js

Issue 6445: This change removes the %AddProperty native JavaScript function from V8.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/math.js ('k') | src/regexp-delay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
===================================================================
--- src/messages.js (revision 423)
+++ src/messages.js (working copy)
@@ -163,7 +163,7 @@
* Setup the Script function and constructor.
*/
%FunctionSetInstanceClassName(Script, 'Script');
-%AddProperty(Script.prototype, 'constructor', Script, DONT_ENUM);
+%SetProperty(Script.prototype, 'constructor', Script, DONT_ENUM);
%SetCode(Script, function(x) {
// Script objects can only be created by the VM.
throw new $Error("Not supported");
@@ -633,7 +633,7 @@
// effects when overwriting the error functions from
// user code.
var name = f.name;
- %AddProperty(global, name, f, DONT_ENUM);
+ %SetProperty(global, name, f, DONT_ENUM);
this['$' + name] = f;
// Configure the error function.
// prototype of 'Error' must be as default: new Object().
@@ -663,7 +663,7 @@
// Setup extra properties of the Error.prototype object.
$Error.prototype.message = '';
-%AddProperty($Error.prototype, 'toString', function toString() {
+%SetProperty($Error.prototype, 'toString', function toString() {
var type = this.type;
if (type && !this.hasOwnProperty("message")) {
return this.name + ": " + FormatMessage({ type: type, args: this.arguments });
« no previous file with comments | « src/math.js ('k') | src/regexp-delay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698