Issue 6413014: Original patch from issue 570048

Issue 6413014: Original patch from issue 570048 (Closed)

Created:
9 years, 10 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
andersrb

CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Original patch from issue 570048 BUG=30583 TEST=

Patch Set 2 : a few fixes #

Total comments: 5

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+584 lines, -52 lines)			Patch
M	chrome/browser/extensions/extension_function_dispatcher.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_apitest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View	1	1 chunk	+82 lines, -0 lines	3 comments	Download
M	chrome/browser/host_zoom_map.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/host_zoom_map.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/host_zoom_map_unittest.cc	View		6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_message_filter.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_message_filter.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	3 chunks	+18 lines, -4 lines	1 comment	Download
M	chrome/common/extensions/api/extension_api.json	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/tabs/zoom/icon.png	View		Binary file		0 comments	Download
A	chrome/common/extensions/docs/examples/api/tabs/zoom/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/docs/examples/api/tabs/zoom/popup.html	View		1 chunk	+154 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	4 chunks	+7 lines, -4 lines	1 comment	Download
M	chrome/renderer/render_view.cc	View	1	5 chunks	+21 lines, -21 lines	0 comments	Download
M	chrome/renderer/resources/json_schema.js	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/zoom_getset/blank.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/zoom_getset/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/zoom_getset/test.html	View	1	1 chunk	+149 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/6413014/diff/1/chrome/browser/extensions/extension_tabs_module.cc File chrome/browser/extensions/extension_tabs_module.cc (right): http://codereview.chromium.org/6413014/diff/1/chrome/browser/extensions/extension_tabs_module.cc#newcode1008 chrome/browser/extensions/extension_tabs_module.cc:1008: registrar_.RemoveAll(); I wasn't sure why this was needed, since ...

9 years, 10 months ago (2011-02-07 09:26:55 UTC) #1

andersrb

9 years, 10 months ago (2011-02-07 15:14:10 UTC) #2

http://codereview.chromium.org/6413014/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/6413014/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tabs_module.cc:1008: registrar_.RemoveAll();
On 2011/02/07 09:26:55, Aaron Boodman wrote:
> I wasn't sure why this was needed, since it happens automatically when the
> object is destroyed. Was there some reason?

No. I probably copied it from another observer. I don't even know what it does
;)

Expand Messages | Collapse Messages