Issue 6400006: Fix style problems in Balloon stuff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6400006: Fix style problems in Balloon stuff (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix style problems in the Balloon implementation on linux in preparation for turning on chrome-style bot. - Rename file that had all BalloonCollectionImpl code from balloon_collection.cc to balloon_collection_impl.cc so I could add a real balloon_collection.cc for deinlining. - GTK implementation files shouldn't depend on views/ code. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73019

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+378 lines, -363 lines)			Patch
M	chrome/browser/notifications/balloon_collection.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.cc	View	1 chunk	+5 lines, -354 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/notifications/balloon_collection_impl.cc	View	1 chunk	+365 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/notifications/balloon_view_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lg

Expand Messages | Collapse Messages