Adds some debugging code in hopes of isolating a crash.

Adds some debugging code in hopes of isolating a crash.

BUG=58853
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72550

[sky, 2011-01-25 18:06:31]

Yes, this looks like a ton of redundant checks. As far as I can tell from the
crash though some where along the line the RVH goes NULL. I'm trying to figure
out where.

  -Scott

[Ben Goodger (Google), 2011-01-25 20:07:13]

OK

On Tue, Jan 25, 2011 at 10:06 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Message:
> Yes, this looks like a ton of redundant checks. As far as I can tell from
> the
> crash though some where along the line the RVH goes NULL. I'm trying to
> figure
> out where.
>
>  -Scott
>
> Description:
> Adds some debugging code in hopes of isolating a crash.
>
> BUG=58853
> TEST=none
>
> Please review this at http://codereview.chromium.org/6395002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/views/hung_renderer_view.cc
>
>
> Index: chrome/browser/ui/views/hung_renderer_view.cc
> diff --git a/chrome/browser/ui/views/hung_renderer_view.cc
> b/chrome/browser/ui/views/hung_renderer_view.cc
> index
>
99610bbf2d588027e213ac3cd90dbaba75c1dca5..08fdb94f76bdbe37bd6196faadfc622dbc5be6fc
> 100644
> --- a/chrome/browser/ui/views/hung_renderer_view.cc
> +++ b/chrome/browser/ui/views/hung_renderer_view.cc
> @@ -72,8 +72,13 @@ HungPagesTableModel::~HungPagesTableModel() {
>  }
>
>  void HungPagesTableModel::InitForTabContents(TabContents* hung_contents) {
> +  // TODO(sky): remove when figure out cause of 58853.
> +  CHECK(contents->render_view_host());
>   tab_contentses_.clear();
>   for (TabContentsIterator it; !it.done(); ++it) {
> +    // TODO(sky): remove when figure out cause of 58853.
> +    CHECK(contents->render_view_host());
> +    CHECK(hung_contents->render_view_host());
>     if (it->GetRenderProcessHost() ==
> hung_contents->GetRenderProcessHost())
>       tab_contentses_.push_back(*it);
>   }
> @@ -226,6 +231,8 @@ HungRendererDialogView::~HungRendererDialogView() {
>
>  void HungRendererDialogView::ShowForTabContents(TabContents* contents) {
>   DCHECK(contents && window());
> +  // TODO(sky): remove when figure out cause of 58853.
> +  CHECK(contents->render_view_host());
>   contents_ = contents;
>
>   // Don't show the warning unless the foreground window is the frame, or
> this
> @@ -239,6 +246,9 @@ void
> HungRendererDialogView::ShowForTabContents(TabContents* contents) {
>   }
>
>   if (!window()->IsActive()) {
> +    // TODO(sky): remove when figure out cause of 58853.
> +    CHECK(contents->render_view_host());
> +
>     gfx::Rect bounds = GetDisplayBounds(contents);
>     window()->SetBounds(bounds, frame_hwnd);
>
> @@ -449,6 +459,8 @@ static HungRendererDialogView*
> CreateHungRendererDialogView() {
>  namespace hung_renderer_dialog {
>
>  void ShowForTabContents(TabContents* contents) {
> +  // TODO(sky): remove when figure out cause of 58853.
> +  CHECK(contents->render_view_host());
>   if (!logging::DialogsAreSuppressed()) {
>     if (!g_instance)
>       g_instance = CreateHungRendererDialogView();
>
>
>