Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: chrome/browser/ui/views/hung_renderer_view.cc

Issue 6395002: Adds some debugging code in hopes of isolating a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix check Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/hung_renderer_view.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc
index 99610bbf2d588027e213ac3cd90dbaba75c1dca5..393ce69ced08abeca2db2b91a15e6df6a282406e 100644
--- a/chrome/browser/ui/views/hung_renderer_view.cc
+++ b/chrome/browser/ui/views/hung_renderer_view.cc
@@ -72,8 +72,13 @@ HungPagesTableModel::~HungPagesTableModel() {
}
void HungPagesTableModel::InitForTabContents(TabContents* hung_contents) {
+ // TODO(sky): remove when figure out cause of 58853.
+ CHECK(hung_contents->render_view_host());
tab_contentses_.clear();
for (TabContentsIterator it; !it.done(); ++it) {
+ // TODO(sky): remove when figure out cause of 58853.
+ CHECK(it->render_view_host());
+ CHECK(hung_contents->render_view_host());
if (it->GetRenderProcessHost() == hung_contents->GetRenderProcessHost())
tab_contentses_.push_back(*it);
}
@@ -226,6 +231,8 @@ HungRendererDialogView::~HungRendererDialogView() {
void HungRendererDialogView::ShowForTabContents(TabContents* contents) {
DCHECK(contents && window());
+ // TODO(sky): remove when figure out cause of 58853.
+ CHECK(contents->render_view_host());
contents_ = contents;
// Don't show the warning unless the foreground window is the frame, or this
@@ -239,6 +246,9 @@ void HungRendererDialogView::ShowForTabContents(TabContents* contents) {
}
if (!window()->IsActive()) {
+ // TODO(sky): remove when figure out cause of 58853.
+ CHECK(contents->render_view_host());
+
gfx::Rect bounds = GetDisplayBounds(contents);
window()->SetBounds(bounds, frame_hwnd);
@@ -449,6 +459,8 @@ static HungRendererDialogView* CreateHungRendererDialogView() {
namespace hung_renderer_dialog {
void ShowForTabContents(TabContents* contents) {
+ // TODO(sky): remove when figure out cause of 58853.
+ CHECK(contents->render_view_host());
if (!logging::DialogsAreSuppressed()) {
if (!g_instance)
g_instance = CreateHungRendererDialogView();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698