Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 6392042: Propagate the user gesture state. It is necessary to do correct pop-up blocki... (Closed)

Created:
9 years, 10 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Propagate the user gesture state. It is necessary to do correct pop-up blocking if a plug-in tries to open an URL in a new frame. No behaviour changes yet -- those require a separate change to the WebKit chromium directory, that uses the propagated state. BUG=70538 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webkit/plugins/npapi/webplugin_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
Piece 1 -- this will allow us to set a correct user gesture state around ...
9 years, 10 months ago (2011-02-01 05:33:17 UTC) #1
abarth-chromium
Test?
9 years, 10 months ago (2011-02-01 20:43:23 UTC) #2
Chris Evans
On 2011/02/01 20:43:23, abarth wrote: > Test? There is no behaviour change (yet).
9 years, 10 months ago (2011-02-01 20:58:12 UTC) #3
abarth-chromium
9 years, 10 months ago (2011-02-01 21:50:17 UTC) #4
Ok.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698