Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: webkit/plugins/npapi/webplugin_impl.cc

Issue 6392042: Propagate the user gesture state. It is necessary to do correct pop-up blocki... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/webplugin_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/webplugin_impl.cc
===================================================================
--- webkit/plugins/npapi/webplugin_impl.cc (revision 73070)
+++ webkit/plugins/npapi/webplugin_impl.cc (working copy)
@@ -659,6 +659,7 @@
WebPluginImpl::RoutingStatus WebPluginImpl::RouteToFrame(
const char* url,
bool is_javascript_url,
+ bool popups_allowed,
const char* method,
const char* target,
const char* buf,
@@ -715,6 +716,7 @@
request.setHTTPMethod(WebString::fromUTF8(method));
request.setFirstPartyForCookies(
webframe_->document().firstPartyForCookies());
+ request.setHasUserGesture(popups_allowed);
if (len > 0) {
if (!SetPostData(&request, buf, len)) {
// Uhoh - we're in trouble. There isn't a good way
@@ -1078,8 +1080,8 @@
// to the plugin's frame.
bool is_javascript_url = StartsWithASCII(url, "javascript:", false);
RoutingStatus routing_status = RouteToFrame(
- url, is_javascript_url, method, target, buf, len, notify_id,
- referrer_flag);
+ url, is_javascript_url, popups_allowed, method, target, buf, len,
+ notify_id, referrer_flag);
if (routing_status == ROUTED)
return;
« no previous file with comments | « webkit/plugins/npapi/webplugin_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698