Issue 6389002: Patch to restore 6267009 (move about:flags from profile to local state)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6389002: Patch to restore 6267009 (move about:flags from profile to local state) (Closed)

Created:
9 years, 11 months ago by bbudge

Modified:
9 years, 7 months ago

Reviewers:
stevenjb (google-dont-use), zelidrag, Nico, Miranda Callahan

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. It restores 6267009 http://codereview.chromium.org/6267009/ which got reverted because it broke ChromeOS tests. The patch also removes some migration code for ChromeOS experiments. Users' settings should be migrated by now. This is a release blocker for NaCl, so we are pushing this through. TEST=manual BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72404

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -36 lines)			Patch
M	chrome/browser/about_flags.cc	View		2 chunks	+0 lines, -25 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/flags_ui.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/flags_ui.cc	View	1	4 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Miranda Callahan

On 2011/01/24 19:57:16, bbudge1 wrote: LGTM if ChromeOS tests pass -- thank you!

9 years, 11 months ago (2011-01-24 20:12:03 UTC) #2

Nico

9 years, 11 months ago (2011-01-24 22:46:33 UTC) #3

Lg with green chromeos try.
On Jan 24, 2011 11:57 AM, <bbudge@chromium.org> wrote: