Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: chrome/browser/about_flags.cc

Issue 6389002: Patch to restore 6267009 (move about:flags from profile to local state) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
===================================================================
--- chrome/browser/about_flags.cc (revision 72357)
+++ chrome/browser/about_flags.cc (working copy)
@@ -314,25 +314,6 @@
DISALLOW_COPY_AND_ASSIGN(FlagsState);
};
-#if defined(OS_CHROMEOS)
-// Migrates Chrome OS Labs settings to experiments adding flags to enabled
-// experiment list if the corresponding pref is on.
-void MigrateChromeOSLabsPrefs(PrefService* prefs,
- std::set<std::string>* result) {
- DCHECK(prefs);
- DCHECK(result);
- if (prefs->GetBoolean(prefs::kLabsMediaplayerEnabled))
- result->insert(kMediaPlayerExperimentName);
- if (prefs->GetBoolean(prefs::kLabsAdvancedFilesystemEnabled))
- result->insert(kAdvancedFileSystemExperimentName);
- if (prefs->GetBoolean(prefs::kUseVerticalTabs))
- result->insert(kVerticalTabsExperimentName);
- prefs->SetBoolean(prefs::kLabsMediaplayerEnabled, false);
- prefs->SetBoolean(prefs::kLabsAdvancedFilesystemEnabled, false);
- prefs->SetBoolean(prefs::kUseVerticalTabs, false);
-}
-#endif
-
// Extracts the list of enabled lab experiments from preferences and stores them
// in a set.
void GetEnabledFlags(const PrefService* prefs, std::set<std::string>* result) {
@@ -557,12 +538,6 @@
std::set<std::string> enabled_experiments;
-#if defined(OS_CHROMEOS)
- // Some experiments were implemented via prefs on Chrome OS and we want to
- // seamlessly migrate these prefs to about:flags for updated users.
- MigrateChromeOSLabsPrefs(prefs, &enabled_experiments);
-#endif
-
GetSanitizedEnabledFlagsForCurrentPlatform(prefs, &enabled_experiments);
typedef std::map<std::string, std::string> NameToSwitchMap;
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698