Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 6382003: Reorder the methods in net/url_request/. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

Reorder the methods in net/url_request/. BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72013

Patch Set 1 #

Patch Set 2 : Compiling net_unittests != compiling the rest of chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1352 lines, -1353 lines) Patch
M net/base/listen_socket.h View 3 chunks +10 lines, -9 lines 0 comments Download
M net/base/listen_socket.cc View 6 chunks +85 lines, -85 lines 0 comments Download
M net/url_request/https_prober.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/https_prober.cc View 3 chunks +26 lines, -26 lines 0 comments Download
M net/url_request/url_request.h View 5 chunks +16 lines, -16 lines 0 comments Download
M net/url_request/url_request_data_job.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_data_job.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_filter.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 3 chunks +9 lines, -10 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 3 chunks +99 lines, -99 lines 0 comments Download
M net/url_request/url_request_http_job.h View 2 chunks +25 lines, -25 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 3 chunks +563 lines, -562 lines 0 comments Download
M net/url_request/url_request_job.h View 3 chunks +6 lines, -11 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 10 chunks +416 lines, -416 lines 0 comments Download
M net/url_request/url_request_job_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_throttler_entry.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 3 chunks +41 lines, -41 lines 0 comments Download
M net/url_request/url_request_throttler_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 3 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
More cleanup patches; this time mostly contained in net/url_request/
9 years, 11 months ago (2011-01-20 17:54:10 UTC) #1
willchan no longer on Chromium
LGTM On Thu, Jan 20, 2011 at 9:54 AM, <erg@chromium.org> wrote: > Reviewers: eroman, willchan, ...
9 years, 11 months ago (2011-01-20 21:25:21 UTC) #2
mmenke
Looks fine to me, too, but I'm not terribly familiar with most of the code ...
9 years, 11 months ago (2011-01-20 21:30:11 UTC) #3
Elliot Glaysher
9 years, 11 months ago (2011-01-20 21:41:10 UTC) #4
On 2011/01/20 21:30:11, Matt Menke wrote:
> Looks fine to me, too, but I'm not terribly familiar with most of the code
> involved, so I'm removing myself as a reviewer.

(Sorry Matt. Your name came up on a blame of the url_request/ directory so I
just assumed that you worked there often enough)

Powered by Google App Engine
This is Rietveld 408576698