Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: net/url_request/url_request_job.h

Issue 6382003: Reorder the methods in net/url_request/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compiling net_unittests != compiling the rest of chrome Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index 23a32323da9693c3ab6355282f05660f14d6aba2..3ac648b67d9c7a2915566e84256bd365d318b8d6 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -129,13 +129,6 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
virtual bool GetContentEncodings(
std::vector<Filter::FilterType>* encoding_types);
- // Find out if this is a download.
- virtual bool IsDownload() const;
-
- // Find out if this is a response to a request that advertised an SDCH
- // dictionary. Only makes sense for some types of requests.
- virtual bool IsSdchResponse() const;
-
// Called to setup stream filter for this request. An example of filter is
// content encoding/decoding.
void SetupFilter();
@@ -208,6 +201,8 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
virtual bool GetMimeType(std::string* mime_type) const;
virtual bool GetURL(GURL* gurl) const;
virtual base::Time GetRequestTime() const;
+ virtual bool IsDownload() const;
+ virtual bool IsSdchResponse() const;
virtual bool IsCachedContent() const;
virtual int64 GetByteReadCount() const;
virtual int GetResponseCode() const;
@@ -277,16 +272,16 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
// to get SDCH to emit stats.
void DestroyFilters() { filter_.reset(); }
- // The request that initiated this job. This value MAY BE NULL if the
- // request was released by DetachRequest().
- net::URLRequest* request_;
-
// The status of the job.
const net::URLRequestStatus GetStatus();
// Set the status of the job.
void SetStatus(const net::URLRequestStatus& status);
+ // The request that initiated this job. This value MAY BE NULL if the
+ // request was released by DetachRequest().
+ net::URLRequest* request_;
+
// Whether the job is doing performance profiling
bool is_profiling_;
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698