Implement a poor mans redirect handling in ChromeFrame for browsers which don...

Implement poor man's redirect handling in ChromeFrame for browsers which don't implement
the NPAPI redirect notification spec.

We compare the URL received in the NewStream notification with the requested URL and if they
differ we cancel the current request and inform Chrome that this was a redirect. The sideeffect
would be that there would be two GET requests sent out.

BUG=69419
TEST=none.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72029

[Sigurður Ásgeirsson, 2011-01-20 21:39:36]

lgtm, except I can't say I understand the stream lifetime in this case.

http://codereview.chromium.org/6381005/diff/1/chrome_frame/npapi_url_request.cc
File chrome_frame/npapi_url_request.cc (right):

http://codereview.chromium.org/6381005/diff/1/chrome_frame/npapi_url_request....
chrome_frame/npapi_url_request.cc:389: return NPERR_GENERIC_ERROR;
do you need to destroy the stream with npapi::DestroyStream before returning?

[amit, 2011-01-20 21:46:08]

lgtm

[ananta, 2011-01-20 22:52:00]

http://codereview.chromium.org/6381005/diff/1/chrome_frame/npapi_url_request.cc
File chrome_frame/npapi_url_request.cc (right):

http://codereview.chromium.org/6381005/diff/1/chrome_frame/npapi_url_request....
chrome_frame/npapi_url_request.cc:389: return NPERR_GENERIC_ERROR;
On 2011/01/20 21:39:36, Ruðrugis wrote:
> do you need to destroy the stream with npapi::DestroyStream before returning? 

No. The host should destroy the stream on receiving an error.