Implement a poor mans redirect handling in ChromeFrame for browsers which don...

chrome_frame/npapi_url_request.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/npapi_url_request.h"
 
 #include "base/string_number_conversions.h"
 #include "base/threading/platform_thread.h"
+#include "chrome_frame/chrome_frame_npapi.h"
 #include "chrome_frame/np_browser_functions.h"
 #include "chrome_frame/np_utils.h"
 #include "net/base/net_errors.h"
 
 class NPAPIUrlRequest : public PluginUrlRequest {
  public:
   explicit NPAPIUrlRequest(NPP instance);
   ~NPAPIUrlRequest();
 
   virtual bool Start();
@@ skipping 344 matching lines @@
     return NPERR_NO_ERROR;
 
   // This stream is being constructed for a request that has already been
   // canceled.  Signal its immediate termination.
   if (net::URLRequestStatus::CANCELED == request->status().status()) {
     return npapi::DestroyStream(request->instance(),
                                 stream, NPRES_USER_BREAK);
   }
 
   DCHECK(request_map_.find(request->id()) != request_map_.end());
+
+  // If the host browser does not support the NPAPI redirect notification
+  // spec, and if the request URL is implicitly redirected, we need to
+  // inform Chrome about the redirect and allow it to follow the redirect.
+  // We achieve this by comparing the URL requested with the URL received in
+  // the response and if they don't match we assume a redirect. This would have
+  // a sideffect that two GET requests would be sent out in this case.
+  if (!BrowserSupportsRedirectNotification()) {
+    if (GURL(request->url().c_str()) != GURL(stream->url)) {
+      DVLOG(1) << "Request URL:"
+               << request->url()
+               << " was redirected to:"
+               << stream->url;
+      delegate_->OnResponseStarted(request->id(), "", "", 0, base::Time(),
+                                   stream->url, 302);
+      return NPERR_GENERIC_ERROR;

[Sigurður Ásgeirsson, 2011/01/20 21:39:36]

do you need to destroy the stream with npapi::DestroyStream before returning? 

[ananta, 2011/01/20 22:52:00]

No. The host should destroy the stream on receiving an error.

+    }
+  }
   // We need to return the requested stream mode if we are returning a success
   // code. If we don't do this it causes Opera to blow up.
   *stream_type = NP_NORMAL;
   return request->OnStreamCreated(type, stream);
 }
 
 int32 NPAPIUrlRequestManager::WriteReady(NPStream* stream) {
   NPAPIUrlRequest* request = RequestFromNotifyData(stream->notifyData);
   if (!request)
     return 0x7FFFFFFF;
@@ skipping 48 matching lines @@
   }
 }
 
 scoped_refptr<NPAPIUrlRequest> NPAPIUrlRequestManager::LookupRequest(
     int request_id) {
   RequestMap::iterator index = request_map_.find(request_id);
   if (index != request_map_.end())
     return index->second;
   return NULL;
 }