Fix a CHECK failure in AutocompletePopupModel::InfoForCurrentSelection().

Fix a CHECK failure in AutocompletePopupModel::InfoForCurrentSelection().

BUG=70344
TEST=See bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72417

[Peter Kasting, 2011-01-21 23:58:15]

http://codereview.chromium.org/6380012/diff/1/chrome/browser/autocomplete/aut...
File chrome/browser/autocomplete/autocomplete_edit.cc (right):

http://codereview.chromium.org/6380012/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit.cc:491: if (has_temporary_text_ &&
popup_->IsOpen()) {
It should be an invariant here that the popup is open.  Anything that closes the
popup should cause us to accept the temporary text as the user text.  (See
http://code.google.com/p/chromium/issues/detail?id=63425#c3 .)

The right fix is that we should look through the different codepaths that close
the popup and ensure they're consistent about doing this.

[James Su, 2011-01-22 03:41:54]

A better solution :)

[Peter Kasting, 2011-01-24 22:10:19]

LGTM

http://codereview.chromium.org/6380012/diff/5001/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_popup_model.cc (right):

http://codereview.chromium.org/6380012/diff/5001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_popup_model.cc:322: 
Nit: Unnecessary blank line

http://codereview.chromium.org/6380012/diff/5001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_popup_model.cc:326:
edit_model_->PopupBoundsChangedTo(gfx::Rect());
Nit: Let's roll this call into the body of OnPopupClosed().  That will make the
API a little simpler to use and let us get rid of the braces here too.