Fix a CHECK failure in AutocompletePopupModel::InfoForCurrentSelection().

chrome/browser/autocomplete/autocomplete_edit.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/metrics/histogram.h"
@@ skipping 470 matching lines @@
   paste_state_ = NONE;
 
   // Like typing, killing focus "accepts" the temporary text as the user
   // text, because it makes little sense to have temporary text when the
   // popup is closed.
   InternalSetUserText(UserTextFromDisplayText(view_->GetText()));
   has_temporary_text_ = false;
 }
 
 bool AutocompleteEditModel::OnEscapeKeyPressed() {
-  if (has_temporary_text_) {
+  if (has_temporary_text_ && popup_->IsOpen()) {

[Peter Kasting, 2011/01/21 23:58:15]

It should be an invariant here that the popup is open.  Anything that closes the
popup should cause us to accept the temporary text as the user text.  (See
http://code.google.com/p/chromium/issues/detail?id=63425#c3 .)

The right fix is that we should look through the different codepaths that close
the popup and ensure they're consistent about doing this.

     AutocompleteMatch match;
     popup_->InfoForCurrentSelection(&match, NULL);
     if (match.destination_url != original_url_) {
       // The user typed something, then selected a different item.  Restore the
       // text they typed and change back to the default item.
       // NOTE: This purposefully does not reset paste_state_.
       just_deleted_text_ = false;
       has_temporary_text_ = false;
       popup_->ResetToDefaultMatch();
       view_->OnRevertTemporaryText();
@@ skipping 291 matching lines @@
 //  static
 bool AutocompleteEditModel::IsSpaceCharForAcceptingKeyword(wchar_t c) {
   switch (c) {
     case 0x0020:  // Space
     case 0x3000:  // Ideographic Space
       return true;
     default:
       return false;
   }
 }