chrome/browser/renderer_host/render_widget_host_view_views.cc - Issue 6380005: Implement RenderWidgetHostViewViews::Destroy. See RWHVGtk for reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6380005: Implement RenderWidgetHostViewViews::Destroy. See RWHVGtk for reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/render_widget_host_view_views.cc

diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc

index 80804ad5b531c015aeb45955a65dcc86cdb923bc..055e8173625dbb2577ff8a551b5323933eb380e6 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_views.cc

+++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc

@@ -293,8 +293,8 @@ void RenderWidgetHostViewViews::RenderViewGone(base::TerminationStatus status,

}

void RenderWidgetHostViewViews::Destroy() {

- // TODO(anicolao): deal with any special popup cleanup

- NOTIMPLEMENTED();

+ // host_'s destruction brought us here, null it out so we don't use it

+ host_ = NULL;

bryeung 2011/01/19 18:13:57 You don't need the DeleteSoon call that RWHVGtk ha

}

void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »