Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 6380005: Implement RenderWidgetHostViewViews::Destroy. See RWHVGtk for reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h" 5 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 } 286 }
287 } 287 }
288 288
289 void RenderWidgetHostViewViews::RenderViewGone(base::TerminationStatus status, 289 void RenderWidgetHostViewViews::RenderViewGone(base::TerminationStatus status,
290 int error_code) { 290 int error_code) {
291 GetRenderWidgetHost()->ViewDestroyed(); 291 GetRenderWidgetHost()->ViewDestroyed();
292 Destroy(); 292 Destroy();
293 } 293 }
294 294
295 void RenderWidgetHostViewViews::Destroy() { 295 void RenderWidgetHostViewViews::Destroy() {
296 // TODO(anicolao): deal with any special popup cleanup 296 // host_'s destruction brought us here, null it out so we don't use it
297 NOTIMPLEMENTED(); 297 host_ = NULL;
bryeung 2011/01/19 18:13:57 You don't need the DeleteSoon call that RWHVGtk ha
298 } 298 }
299 299
300 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) { 300 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {
301 // TODO(anicolao): decide if we want tooltips for touch (none specified 301 // TODO(anicolao): decide if we want tooltips for touch (none specified
302 // right now/might want a press-and-hold display) 302 // right now/might want a press-and-hold display)
303 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove 303 // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove
304 } 304 }
305 305
306 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) { 306 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) {
307 // TODO(anicolao): deal with the clipboard without GTK 307 // TODO(anicolao): deal with the clipboard without GTK
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 } 753 }
754 754
755 // static 755 // static
756 RenderWidgetHostView* 756 RenderWidgetHostView*
757 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView( 757 RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
758 gfx::NativeView widget) { 758 gfx::NativeView widget) {
759 gpointer user_data = g_object_get_data(G_OBJECT(widget), 759 gpointer user_data = g_object_get_data(G_OBJECT(widget),
760 kRenderWidgetHostViewKey); 760 kRenderWidgetHostViewKey);
761 return reinterpret_cast<RenderWidgetHostView*>(user_data); 761 return reinterpret_cast<RenderWidgetHostView*>(user_data);
762 } 762 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698