Issue 6380004: [Sync] Tidy up SyncBackendHost interface.

Issue 6380004: [Sync] Tidy up SyncBackendHost interface. (Closed)

Created:
9 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Tidy up SyncBackendHost interface. Converted passphrase-related notifications to SyncFrontend methods. Removed some unneeded parameters from SyncBackendHost constructor. Moved some function definitions into .cc files. BUG=None TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71855

Patch Set 1 #

Patch Set 2 : Fix lint #

Patch Set 3 : Fix windows compile #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -209 lines)			Patch
M	chrome/browser/sync/glue/data_type_manager_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl_unittest.cc	View		12 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View	1	4 chunks	+18 lines, -9 lines	1 comment	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1 2	5 chunks	+23 lines, -23 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_mock.h	View		1 chunk	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_mock.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		19 chunks	+55 lines, -73 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View		6 chunks	+34 lines, -19 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_test_util.h	View	1 2	1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View		5 chunks	+9 lines, -17 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View	1 2	2 chunks	+31 lines, -26 lines	1 comment	Download
	chrome/common/notification_type.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM ++! http://codereview.chromium.org/6380004/diff/13002/chrome/browser/sync/glue/sync_backend_host.h File chrome/browser/sync/glue/sync_backend_host.h (right): http://codereview.chromium.org/6380004/diff/13002/chrome/browser/sync/glue/sync_backend_host.h#newcode85 chrome/browser/sync/glue/sync_backend_host.h:85: virtual void OnPassphraseAccepted() = 0; sweet, so ...

9 years, 11 months ago (2011-01-19 20:42:53 UTC) #2

akalin

9 years, 11 months ago (2011-01-19 21:04:54 UTC) #3

On 2011/01/19 20:42:53, timsteele wrote:
> LGTM ++!
> 
http://codereview.chromium.org/6380004/diff/13002/chrome/browser/sync/glue/sy...
> chrome/browser/sync/glue/sync_backend_host.h:85: virtual void
> OnPassphraseAccepted() = 0;
> sweet, so you gonna write a sync_backend_host_unittest now? :)

I may have to for the next change I have planned!!

http://codereview.chromium.org/6380004/diff/13002/chrome/browser/sync/test_pr...
> chrome/browser/sync/test_profile_sync_service.cc:45:
> HandleInitializationCompletedOnFrontendLoop() {
> hmm.. I thought the consensus for this was to not indent 4 spaces and keep it
> lined up, but I can't find the discussion at the moment :\

Consulted IRC, indent 4 spaces according to isherman@.  Although emacs agrees
with you.

Expand Messages | Collapse Messages