Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2508)

Unified Diff: chrome/browser/sync/test_profile_sync_service.h

Issue 6380004: [Sync] Tidy up SyncBackendHost interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows compile Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test_profile_sync_service.h
diff --git a/chrome/browser/sync/test_profile_sync_service.h b/chrome/browser/sync/test_profile_sync_service.h
index 04160065245a08eaa46f3c405a031b8abd09cdf0..b1d6ef4627b90533f20f61ffe5193521dffe9446 100644
--- a/chrome/browser/sync/test_profile_sync_service.h
+++ b/chrome/browser/sync/test_profile_sync_service.h
@@ -65,8 +65,6 @@ class SyncBackendHostForProfileSyncTest : public SyncBackendHost {
SyncBackendHostForProfileSyncTest(
TestProfileSyncService* service,
Profile* profile,
- const FilePath& profile_path,
- const DataTypeController::TypeMap& data_type_controllers,
Task* initial_condition_setup_task,
int num_expected_resumes,
int num_expected_pauses,
@@ -93,10 +91,13 @@ class SyncBackendHostForProfileSyncTest : public SyncBackendHost {
}
}
- virtual void ConfigureDataTypes(const syncable::ModelTypeSet& types,
+ virtual void ConfigureDataTypes(
+ const DataTypeController::TypeMap& data_type_controllers,
+ const syncable::ModelTypeSet& types,
CancelableTask* ready_task) {
SetAutofillMigrationState(syncable::MIGRATED);
- SyncBackendHost::ConfigureDataTypes(types, ready_task);
+ SyncBackendHost::ConfigureDataTypes(
+ data_type_controllers, types, ready_task);
}
// Called when a nudge comes in.
@@ -164,9 +165,7 @@ class TestProfileSyncService : public ProfileSyncService {
const std::string& test_user,
bool synchronous_backend_initialization,
Task* initial_condition_setup_task)
- : ProfileSyncService(factory, profile,
- !test_user.empty() ?
- test_user : ""),
+ : ProfileSyncService(factory, profile, test_user),
synchronous_backend_initialization_(
synchronous_backend_initialization),
synchronous_sync_configuration_(false),
@@ -179,16 +178,6 @@ class TestProfileSyncService : public ProfileSyncService {
}
virtual ~TestProfileSyncService() { }
- virtual void CreateBackend() {
- backend_.reset(new browser_sync::SyncBackendHostForProfileSyncTest(
- this, profile(),
- profile()->GetPath(), data_type_controllers(),
- initial_condition_setup_task_.release(),
- num_expected_resumes_, num_expected_pauses_,
- set_initial_sync_ended_on_init_,
- synchronous_backend_initialization_));
- }
-
virtual void OnBackendInitialized() {
ProfileSyncService::OnBackendInitialized();
// TODO(akalin): Figure out a better way to do this.
@@ -222,6 +211,9 @@ class TestProfileSyncService : public ProfileSyncService {
browser_sync::TestIdFactory* id_factory() { return &id_factory_; }
+ protected:
+ virtual void CreateBackend();
+
private:
// When testing under ChromiumOS, this method must not return an empty
// value value in order for the profile sync service to start.

Powered by Google App Engine
This is Rietveld 408576698