Disable tests that sporadically got SIGSEGV on MAC; tag them with bug number.

Disable tests that sporadically got SIGSEGV on MAC; tag them with bug number.

BUG=chromium:70608
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72485

[Denis Lagno, 2011-01-24 16:21:11]

please take a look

[Paweł Hajdan Jr., 2011-01-24 17:00:26]

Thank you for the follow-up. Please make the commit message more descriptive.

http://codereview.chromium.org/6377006/diff/1/chrome/common/net/url_fetcher_u...
File chrome/common/net/url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6377006/diff/1/chrome/common/net/url_fetcher_u...
chrome/common/net/url_fetcher_unittest.cc:504: #if !defined(OS_MACOSX)
nit: I think it should be #if defined FLAKY #else to avoid a double negation.

Moreover, please change the bug reference to http://crbug.com/60426, and DISABLE
the tests. FLAKY tests still run, so they are affected by crashes (that's also
described in the "how to handle a failing test" document.

[Denis Lagno, 2011-01-24 17:27:10]

http://codereview.chromium.org/6377006/diff/1/chrome/common/net/url_fetcher_u...
File chrome/common/net/url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6377006/diff/1/chrome/common/net/url_fetcher_u...
chrome/common/net/url_fetcher_unittest.cc:504: #if !defined(OS_MACOSX)
On 2011/01/24 17:00:26, Paweł Hajdan Jr. wrote:
> nit: I think it should be #if defined FLAKY #else to avoid a double negation.

Done.  Though the other way round also has its rationale: it is natural to put
"normal" code first and to put "kludge" second.

> Moreover, please change the bug reference to http://crbug.com/60426, and
DISABLE
> the tests. FLAKY tests still run, so they are affected by crashes (that's also
> described in the "how to handle a failing test" document.

Done

[Paweł Hajdan Jr., 2011-01-24 18:41:09]

LGTM with an important comment.

http://codereview.chromium.org/6377006/diff/6001/chrome/common/net/url_fetche...
File chrome/common/net/url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6377006/diff/6001/chrome/common/net/url_fetche...
chrome/common/net/url_fetcher_unittest.cc:506: TEST_F(URLFetcherTest,
DISABLE_DifferentThreadsTest) {
DISABLE -> DISABLED. Please fix entire file.

[Denis Lagno, 2011-01-24 18:44:25]

http://codereview.chromium.org/6377006/diff/6001/chrome/common/net/url_fetche...
File chrome/common/net/url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6377006/diff/6001/chrome/common/net/url_fetche...
chrome/common/net/url_fetcher_unittest.cc:506: TEST_F(URLFetcherTest,
DISABLE_DifferentThreadsTest) {
On 2011/01/24 18:41:09, Paweł Hajdan Jr. wrote:
> DISABLE -> DISABLED.

Done

> Please fix entire file.

nice joke..