Disable tests that sporadically got SIGSEGV on MAC; tag them with bug number.

chrome/common/net/url_fetcher_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop_proxy.h"
 #include "base/threading/thread.h"
 #include "base/synchronization/waitable_event.h"
 #include "build/build_config.h"
 #include "chrome/common/chrome_plugin_lib.h"
 #include "chrome/common/net/url_fetcher.h"
@@ skipping 483 matching lines @@
   ASSERT_TRUE(test_server.Start());
 
   // Create the fetcher on the main thread.  Since IO will happen on the main
   // thread, this will test URLFetcher's ability to do everything on one
   // thread.
   CreateFetcher(test_server.GetURL("defaultresponse"));
 
   MessageLoop::current()->Run();
 }
 
+#if !defined(OS_MACOSX)

[Paweł Hajdan Jr., 2011/01/24 17:00:26]

nit: I think it should be #if defined FLAKY #else to avoid a double negation.

Moreover, please change the bug reference to http://crbug.com/60426, and DISABLE
the tests. FLAKY tests still run, so they are affected by crashes (that's also
described in the "how to handle a failing test" document.

[Denis Lagno, 2011/01/24 17:27:10]

Done.  Though the other way round also has its rationale: it is natural to put
"normal" code first and to put "kludge" second.
Done

+TEST_F(URLFetcherTest, DifferentThreadsTest) {
+#else
+// SIGSEGV on Mac: http://crbug.com/70608
 TEST_F(URLFetcherTest, FLAKY_DifferentThreadsTest) {
+#endif
   net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   // Create a separate thread that will create the URLFetcher.  The current
   // (main) thread will do the IO, and when the fetch is complete it will
   // terminate the main thread's message loop; then the other thread's
   // message loop will be shut down automatically as the thread goes out of
   // scope.
   base::Thread t("URLFetcher test thread");
   ASSERT_TRUE(t.Start());
   t.message_loop()->PostTask(FROM_HERE, new FetcherWrapperTask(this,
       test_server.GetURL("defaultresponse")));
 
   MessageLoop::current()->Run();
 }
 
+#if !defined(OS_MACOSX)
+TEST_F(URLFetcherPostTest, Basic) {
+#else
+// SIGSEGV on Mac: http://crbug.com/70608
 TEST_F(URLFetcherPostTest, FLAKY_Basic) {
+#endif
   net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   CreateFetcher(test_server.GetURL("echo"));
   MessageLoop::current()->Run();
 }
 
 TEST_F(URLFetcherHeadersTest, Headers) {
   net::TestServer test_server(net::TestServer::TYPE_HTTP,
       FilePath(FILE_PATH_LITERAL("net/data/url_request_unittest")));
@@ skipping 63 matching lines @@
   net::URLRequestThrottlerManager::GetInstance()->OverrideEntryForTests(
       url, entry);
 
   CreateFetcher(url);
 
   MessageLoop::current()->Run();
 
   net::URLRequestThrottlerManager::GetInstance()->EraseEntryForTests(url);
 }
 
+#if !defined(OS_MACOSX)
+TEST_F(URLFetcherBadHTTPSTest, BadHTTPSTest) {
+#else
+// SIGSEGV on Mac: http://crbug.com/70608
 TEST_F(URLFetcherBadHTTPSTest, FLAKY_BadHTTPSTest) {
+#endif
   net::TestServer::HTTPSOptions https_options(
       net::TestServer::HTTPSOptions::CERT_EXPIRED);
   net::TestServer test_server(https_options, FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   CreateFetcher(test_server.GetURL("defaultresponse"));
   MessageLoop::current()->Run();
 }
 
+#if !defined(OS_MACOSX)
+TEST_F(URLFetcherCancelTest, ReleasesContext) {
+#else
+// SIGSEGV on Mac: http://crbug.com/70608
 TEST_F(URLFetcherCancelTest, FLAKY_ReleasesContext) {
+#endif
   net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   GURL url(test_server.GetURL("files/server-unavailable.html"));
 
   // Registers an entry for test url. The backoff time is calculated by:
   //     new_backoff = 2.0 * old_backoff + 0
   // The initial backoff is 2 seconds and maximum backoff is 4 seconds.
   // Maximum retries allowed is set to 2.
   scoped_refptr<net::URLRequestThrottlerEntry> entry(
@@ skipping 50 matching lines @@
 
   // Create the fetcher on the main thread.  Since IO will happen on the main
   // thread, this will test URLFetcher's ability to do everything on one
   // thread.
   CreateFetcher(test_server.GetURL("defaultresponse"));
 
   MessageLoop::current()->Run();
 }
 
 }  // namespace.