Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 6373011: Remove the HInstruction utilities taking flag mask arguments. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove the HInstruction utilities taking flag mask arguments. It is a type error to treat a flag (an enum) as if it were a flag mask (an int derived from shifting a bit by the enum value). It is error prone to have functions that take flag mask arguments because they will silently accept flags. Committed: http://code.google.com/p/v8/source/detail?r=6500

Patch Set 1 #

Patch Set 2 : Fix silly typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -136 lines) Patch
M src/hydrogen-instructions.h View 1 17 chunks +25 lines, -133 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-26 15:22:17 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 11 months ago (2011-01-26 15:26:24 UTC) #2
fschneider
9 years, 11 months ago (2011-01-26 15:43:15 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698