Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 6373011: Remove the HInstruction utilities taking flag mask arguments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Patch Set: Fix silly typo. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 // HValue::DataEquals. The default implementation is UNREACHABLE. We 522 // HValue::DataEquals. The default implementation is UNREACHABLE. We
523 // don't actually care whether DataEquals returns true or false here. 523 // don't actually care whether DataEquals returns true or false here.
524 if (CheckFlag(kUseGVN)) DataEquals(this); 524 if (CheckFlag(kUseGVN)) DataEquals(this);
525 } 525 }
526 #endif 526 #endif
527 527
528 528
529 HCall::HCall(int count) : arguments_(Zone::NewArray<HValue*>(count), count) { 529 HCall::HCall(int count) : arguments_(Zone::NewArray<HValue*>(count), count) {
530 for (int i = 0; i < count; ++i) arguments_[i] = NULL; 530 for (int i = 0; i < count; ++i) arguments_[i] = NULL;
531 set_representation(Representation::Tagged()); 531 set_representation(Representation::Tagged());
532 SetFlagMask(AllSideEffects()); 532 SetAllSideEffects();
533 } 533 }
534 534
535 535
536 void HCall::PrintDataTo(StringStream* stream) const { 536 void HCall::PrintDataTo(StringStream* stream) const {
537 stream->Add("("); 537 stream->Add("(");
538 for (int i = 0; i < arguments_.length(); ++i) { 538 for (int i = 0; i < arguments_.length(); ++i) {
539 if (i != 0) stream->Add(", "); 539 if (i != 0) stream->Add(", ");
540 arguments_.at(i)->PrintNameTo(stream); 540 arguments_.at(i)->PrintNameTo(stream);
541 } 541 }
542 stream->Add(")"); 542 stream->Add(")");
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
1117 void HCompare::PrintDataTo(StringStream* stream) const { 1117 void HCompare::PrintDataTo(StringStream* stream) const {
1118 stream->Add(Token::Name(token())); 1118 stream->Add(Token::Name(token()));
1119 stream->Add(" "); 1119 stream->Add(" ");
1120 HBinaryOperation::PrintDataTo(stream); 1120 HBinaryOperation::PrintDataTo(stream);
1121 } 1121 }
1122 1122
1123 1123
1124 void HCompare::SetInputRepresentation(Representation r) { 1124 void HCompare::SetInputRepresentation(Representation r) {
1125 input_representation_ = r; 1125 input_representation_ = r;
1126 if (r.IsTagged()) { 1126 if (r.IsTagged()) {
1127 SetFlagMask(AllSideEffects()); 1127 SetAllSideEffects();
1128 ClearFlag(kUseGVN); 1128 ClearFlag(kUseGVN);
1129 } else { 1129 } else {
1130 ClearFlagMask(AllSideEffects()); 1130 ClearAllSideEffects();
1131 SetFlag(kUseGVN); 1131 SetFlag(kUseGVN);
1132 } 1132 }
1133 } 1133 }
1134 1134
1135 1135
1136 void HParameter::PrintDataTo(StringStream* stream) const { 1136 void HParameter::PrintDataTo(StringStream* stream) const {
1137 stream->Add("%u", index()); 1137 stream->Add("%u", index());
1138 } 1138 }
1139 1139
1140 1140
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1448 1448
1449 1449
1450 void HCheckPrototypeMaps::Verify() { 1450 void HCheckPrototypeMaps::Verify() {
1451 HInstruction::Verify(); 1451 HInstruction::Verify();
1452 ASSERT(HasNoUses()); 1452 ASSERT(HasNoUses());
1453 } 1453 }
1454 1454
1455 #endif 1455 #endif
1456 1456
1457 } } // namespace v8::internal 1457 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698