Issue 6372013: Revert "Reapply change to with/arguments interaction."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6372013: Revert "Reapply change to with/arguments interaction." (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Revert "Reapply change to with/arguments interaction." Revert this change again. Somewhat mysteriously we sometimes get empty contexts that we do not expect in the context chain. Committed: http://code.google.com/p/v8/source/detail?r=6465

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -35 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/scopes.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-evaluate-locals.js	View	3 chunks	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks.

Expand Messages | Collapse Messages