Add common function to determin board and variant values.

Add common function to determin board and variant values.

Change-Id: I9fe8b267a6fe96f3c4049d77cf866d0b6d36ecbe

BUG=None
TEST=setup_board --board tegra2 --variant seaboard

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9bcd841

[robotboy, 2011-01-21 23:52:21]

Next comes the CL that uses this in setup_board and a new burn-u-boot script.

[robotboy, 2011-01-24 22:36:21]

Ping?

[kwwaters_gmail.com, 2011-01-24 22:49:59]

There isn't a style guide, but the rest of the file "tends" to be different
stylistically.

http://codereview.chromium.org/6371008/diff/1/common.sh
File common.sh (right):

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode574
common.sh:574: local flags_variant="${2}"
These variables are unused.

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode576
common.sh:576: BOARD=$(echo "$FLAGS_board" |cut -d '_' -f 1)
Spaces around "|".

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode577
common.sh:577: VARIANT=${FLAGS_variant:-$(echo "$FLAGS_board" |cut -s -d '_' -f
2)}
Should this be "cut -s -d _ -f 2-"  I'm not sure, but I thought you could have
multiple variants.

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode579
common.sh:579: if [ -n "$VARIANT" ] ; then
Drop space between "]" and ";".

[robotboy, 2011-01-24 23:17:00]

Comments addressed, new version uploaded, PTAL.

Thanks,
    Anton

http://codereview.chromium.org/6371008/diff/1/common.sh
File common.sh (right):

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode574
common.sh:574: local flags_variant="${2}"
Ooops, fixed.

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode576
common.sh:576: BOARD=$(echo "$FLAGS_board" |cut -d '_' -f 1)
On 2011/01/24 22:49:59, kwwaters wrote:
> Spaces around "|".

Done.

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode577
common.sh:577: VARIANT=${FLAGS_variant:-$(echo "$FLAGS_board" |cut -s -d '_' -f
2)}
Nope, we ensure that the variant and board names do not have _'s in them in the
cros_overlay_list script.  I do not believe that you can specify multiple
variants.

http://codereview.chromium.org/6371008/diff/1/common.sh#newcode579
common.sh:579: if [ -n "$VARIANT" ] ; then
On 2011/01/24 22:49:59, kwwaters wrote:
> Drop space between "]" and ";".

Done.

[Kenneth Waters, 2011-01-24 23:19:51]

lgtm.