Add common function to determin board and variant values.

common.sh

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Common constants for build scripts
 # This must evaluate properly for both /bin/bash and /bin/sh
 
 # All scripts should die on error unless commands are specifically excepted
 # by prefixing with '!' or surrounded by 'set +e' / 'set -e'.
 # TODO: Re-enable this once shflags is less prone to dying.
@@ skipping 544 matching lines @@
 chroot_hacks_from_outside() {
   # Give args better names.
   local chroot_dir="${1}"
 
   # Add root as a sudoer if not already done.
   if ! sudo grep -q '^root ALL=(ALL) ALL$' "${chroot_dir}/etc/sudoers" ; then
     info "Upgrading old chroot (pre 2010-10-19) - adding root to sudoers"
     sudo bash -c "echo root ALL=\(ALL\) ALL >> \"${chroot_dir}/etc/sudoers\""
   fi
 }
+
+# The board and variant command line options can be used in a number of ways
+# to specify the board and variant.  The board can encode both pieces of
+# information separated by underscores.  Or the variant can be passed using
+# the separate variant option.  This function extracts the canonical board and
+# variant information and provides it in the BOARD, VARIANT and BOARD_VARIANT
+# variables.
+get_board_and_variant() {
+  local flags_board="${1}"
+  local flags_variant="${2}"

[kwwaters_gmail.com, 2011/01/24 22:49:59]

These variables are unused.

[robotboy, 2011/01/24 23:17:00]

Ooops, fixed.

+
+  BOARD=$(echo "$FLAGS_board" |cut -d '_' -f 1)

[kwwaters_gmail.com, 2011/01/24 22:49:59]

Spaces around "|".

[robotboy, 2011/01/24 23:17:00]

Done.

+  VARIANT=${FLAGS_variant:-$(echo "$FLAGS_board" |cut -s -d '_' -f 2)}

[kwwaters_gmail.com, 2011/01/24 22:49:59]

Should this be "cut -s -d _ -f 2-"  I'm not sure, but I thought you could have
multiple variants.

[robotboy, 2011/01/24 23:17:00]

Nope, we ensure that the variant and board names do not have _'s in them in the
cros_overlay_list script.  I do not believe that you can specify multiple
variants.

+
+  if [ -n "$VARIANT" ] ; then

[kwwaters_gmail.com, 2011/01/24 22:49:59]

Drop space between "]" and ";".

[robotboy, 2011/01/24 23:17:00]

Done.

+    BOARD_VARIANT="${BOARD}_${VARIANT}"
+  else
+    BOARD_VARIANT="${BOARD}"
+  fi
+}