Support msysgit with Chromium.

Support msysgit with Chromium.

First step to remove cygwin dependencies. This will remove dependencies with zcsh and allow python scripts to be executed as hooks.

BUG=70550, 70549
TEST=checkout chrome with git, use git cl to upload a cl, revise a cl, commit a cl.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76232

[Mohamed Mansour, 2011-01-23 02:27:59]

These are needed to make msysgit work. The msysgit doesn't understand ~= for the
shell (its not standard for bash) Cygwin uses tcsh to make ~= valid.

We need the sys.executable if we want to run a subprocess.Popen with a python
executable. Windows is strange like that.

[M-A Ruel, 2011-01-23 02:48:20]

I don't mind about enforcing hooks to be written in python but I'm not sure
everyone would appreciate.

One option would be to use this only when msysgit is detected? I don't know if
it's doable.

[Mohamed Mansour, 2011-01-23 02:58:18]

One way to make it doable is to use: sys.platform. On cygwin it will state
'cygwin' on windows it will state 'win32'. Would that good enough?

[M-A Ruel, 2011-01-23 03:00:22]

On 2011/01/23 02:58:18, Mohamed Mansour wrote:
> One way to make it doable is to use: sys.platform. On cygwin it will state
> 'cygwin' on windows it will state 'win32'. Would that good enough?

To me yes.

[M-A Ruel, 2011-01-23 03:00:44]

Adding Anush for insight about Chromium OS.

[Mohamed Mansour, 2011-01-23 18:46:57]

The CL now keeps the old approach as it was (for cygwin users). If it spots a
msysgit user it will verify that the hook is python otherwise it will fail. I
don't know if there is a better way doing that.

[Mohamed Mansour, 2011-01-25 06:02:44]

ping

[M-A Ruel, 2011-01-25 13:00:59]

I would have preferred to have someone else confirm the change.

In any case, LGTM. No need to wait any more.

[Mohamed Mansour, 2011-01-28 23:40:33]

Evan, Anush, your comments?

[Evan Martin, 2011-01-28 23:45:10]

What do you think of the /usr/bin/env idea?

[Mohamed Mansour, 2011-01-29 00:03:19]

Can you please elaborate on the /usr/bin/env idea, are you referring to
"#!/usr/bin/env python"?

[Evan Martin, 2011-01-29 00:58:07]

See mail from nick carter on chromium-dev

[ncarter (slow), 2011-01-29 02:19:05]

http://codereview.chromium.org/6369012/diff/14001/git_cl/git_cl.py
File git_cl/git_cl.py (left):

http://codereview.chromium.org/6369012/diff/14001/git_cl/git_cl.py#oldcode671
git_cl/git_cl.py:671: return RunCommand([hook, upstream_branch],
error_ok=error_ok,
Sorry if my email wasn't totally clear: the entirety of my change was 7
characters, namely changing this line from:

return RunCommand([hook, ...

to:

return RunCommand(["env", hook, ...

This seemed to work, and didn't require platform-detection or parsing the
shebang.  What was not certain, was whether this approach worked across
cygwin/linux/mac.

I'd upload a patch, but my Windows machine is temporarily inaccessible (I just
moved offices).

[Mohamed Mansour, 2011-02-28 02:49:17]

Sorry for the late reply. I removed the git-cl portion for now. The following
patch will make gclient work with msysgit. So far, I have checked out Chromium
on ~3 Win7 machines all needed this patch (with msysgit) 

Let me know if you accept so I can commit it.

[M-A Ruel, 2011-02-28 17:56:24]

On 2011/02/28 02:49:17, Mohamed Mansour wrote:
> Sorry for the late reply. I removed the git-cl portion for now. The following
> patch will make gclient work with msysgit. So far, I have checked out Chromium
> on ~3 Win7 machines all needed this patch (with msysgit) 
> 
> Let me know if you accept so I can commit it.

Patch set #3 lgtm.

[commit-bot: I haz the power, 2011-02-28 17:58:51]

Change committed as 76232