Support msysgit with Chromium.

git_cl/git_cl.py

 #!/usr/bin/python
 # git-cl -- a git-command for integrating reviews on Rietveld
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 import errno
 import logging
 import optparse
 import os
 import re
 import subprocess
@@ skipping 650 matching lines @@
   os.remove(filename)
   stripcomment_re = re.compile(r'^#.*$', re.MULTILINE)
   return stripcomment_re.sub('', text).strip()
 
 
 def RunHook(hook, upstream_branch, error_ok=False):
   """Run a given hook if it exists. By default, we fail on errors."""
   hook = '%s/%s' % (settings.GetRoot(), hook)
   if not os.path.exists(hook):
     return
-  return RunCommand([hook, upstream_branch], error_ok=error_ok,

[ncarter (slow), 2011/01/29 02:19:05]

Sorry if my email wasn't totally clear: the entirety of my change was 7
characters, namely changing this line from:

return RunCommand([hook, ...

to:

return RunCommand(["env", hook, ...

This seemed to work, and didn't require platform-detection or parsing the
shebang.  What was not certain, was whether this approach worked across
cygwin/linux/mac.

I'd upload a patch, but my Windows machine is temporarily inaccessible (I just
moved offices).

-                    redirect_stdout=False)
+  # msysgit requires sys.executable to be present. This assumes all hooks are
+  # scripted in python. Which should be okay.
+  cmd = [hook, upstream_branch]    
+  if sys.platform == 'win32':
+    with open(hook, 'r') as f:
+      if f.readline().startswith('#!/usr/bin/python'):
+        cmd.insert(0, sys.executable)
+      else:
+        DieWithError('It seems your environment is msysgit, and the hook [%s] '
+                     'will not execute correctly. The hook must be scripted '
+                     'in Python for this to work.')
+  return RunCommand(cmd, error_ok=error_ok, redirect_stdout=False)
 
 
 def CMDpresubmit(parser, args):
   """run presubmit tests on the current changelist"""
   parser.add_option('--upload', action='store_true',
                     help='Run upload hook instead of the push/dcommit hook')
   (options, args) = parser.parse_args(args)
 
   # Make sure index is up-to-date before running diff-index.
   RunGit(['update-index', '--refresh', '-q'], error_ok=True)
@@ skipping 584 matching lines @@
             ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))