Issue 6369008: Fix the newly added OverrideUserAgent net test so that it works in ChromeFram...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6369008: Fix the newly added OverrideUserAgent net test so that it works in ChromeFram... (Closed)

Created:
9 years, 11 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
caseq, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the newly added OverrideUserAgent net test so that it works in ChromeFrame where the chromeframe suffix is added to the outgoing UA. BUG=none TEST=Existing OverideUserAgent test should pass in the regular and ChromeFrame case. R=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72228

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	net/url_request/url_request_unittest.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. caseq: just FYI, since you added the URLRequestTestHTTP.OverrideUserAgent unit test. http://codereview.chromium.org/6369008/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): ...

9 years, 11 months ago (2011-01-21 22:11:06 UTC) #2

ananta

9 years, 11 months ago (2011-01-21 22:24:05 UTC) #3

http://codereview.chromium.org/6369008/diff/1/net/url_request/url_request_uni...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/6369008/diff/1/net/url_request/url_request_uni...
net/url_request/url_request_unittest.cc:27: #include "base/string_util.h"
On 2011/01/21 22:11:06, wtc wrote:
> Nit: this should be listed right after "base/string_piece.h".

Done.

http://codereview.chromium.org/6369008/diff/1/net/url_request/url_request_uni...
net/url_request/url_request_unittest.cc:2673:
EXPECT_TRUE(StartsWithASCII(d.data_received(), "Lynx (textmode)", true));
On 2011/01/21 22:11:06, wtc wrote:
> It would be nice to document the purpose of the StartsWithASCII call (to allow
> the suffix added by Chrome Frame).

Done.

Expand Messages | Collapse Messages