Fix the newly added OverrideUserAgent net test so that it works in ChromeFram...

net/url_request/url_request_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_unittest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <shlobj.h>
 #include <windows.h>
 #elif defined(USE_NSS)
 #include "base/nss_util.h"
 #endif
 
 #include <algorithm>
 #include <string>
 
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_number_conversions.h"
 #include "base/string_piece.h"
 #include "base/stringprintf.h"
+#include "base/string_util.h"

[wtc, 2011/01/21 22:11:06]

Nit: this should be listed right after "base/string_piece.h".

[ananta, 2011/01/21 22:24:05]

Done.

 #include "base/utf_string_conversions.h"
 #include "net/base/cookie_monster.h"
 #include "net/base/cookie_policy.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/base/net_log_unittest.h"
 #include "net/base/net_module.h"
 #include "net/base/net_util.h"
 #include "net/base/ssl_connection_status_flags.h"
@@ skipping 2625 matching lines @@
 
   TestDelegate d;
   TestURLRequest
       req(test_server_.GetURL("echoheaderoverride?User-Agent"), &d);
   req.set_context(new TestURLRequestContext());
   net::HttpRequestHeaders headers;
   headers.SetHeader(net::HttpRequestHeaders::kUserAgent, "Lynx (textmode)");
   req.SetExtraRequestHeaders(headers);
   req.Start();
   MessageLoop::current()->Run();
-  EXPECT_EQ(std::string("Lynx (textmode)"), d.data_received());
+  EXPECT_TRUE(StartsWithASCII(d.data_received(), "Lynx (textmode)", true));

[wtc, 2011/01/21 22:11:06]

It would be nice to document the purpose of the StartsWithASCII call (to allow
the suffix added by Chrome Frame).

[ananta, 2011/01/21 22:24:05]

Done.

 }