Issue 6369004: Drag start unexpectedly cancelled. Must always initiate a drag, avoiding...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6369004: Drag start unexpectedly cancelled. Must always initiate a drag, avoiding... (Closed)

Created:
9 years, 11 months ago by Tom Sepez

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Drag start unexpectedly cancelled. Must always initiate a drag, avoiding the "optimization" of not doing so when no targets are apparent, otherwise we break draggable list elements. BUG=69857 TEST=Manually try dragging <li draggable="true">AAA</li> on linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71696

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/ui/gtk/tab_contents_drag_source.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Evan, please review. While the prior fix prevents the browser from crashing on the example ...

9 years, 11 months ago (2011-01-18 17:48:53 UTC) #1

ok, lgtm

Expand Messages | Collapse Messages