chrome/browser/ui/gtk/tab_contents_drag_source.cc - Issue 6369004: Drag start unexpectedly cancelled. Must always initiate a drag, avoiding...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_contents_drag_source.cc

Issue 6369004: Drag start unexpectedly cancelled. Must always initiate a drag, avoiding... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/tab_contents_drag_source.cc

===================================================================

--- chrome/browser/ui/gtk/tab_contents_drag_source.cc (revision 71406)

+++ chrome/browser/ui/gtk/tab_contents_drag_source.cc (working copy)

@@ -100,12 +100,8 @@

targets_mask |= gtk_dnd_util::DIRECT_SAVE_FILE;

}

- // Short-circuit execution if no targets present.

- if (targets_mask == 0) {

- if (tab_contents()->render_view_host())

- tab_contents()->render_view_host()->DragSourceSystemDragEnded();

- return;

- }

+ // NOTE: Begin a drag even if no targets present. Otherwise, things like

+ // draggable list elements will not work.

drop_data_.reset(new WebDropData(drop_data));

« no previous file with comments | « no previous file | no next file » | no next file with comments »