Issue 6366007: Disable sending of page title in Chrome reports.

Issue 6366007: Disable sending of page title in Chrome reports. (Closed)

Created:
9 years, 11 months ago by rkc

Modified:
9 years, 7 months ago

Reviewers:
oshima, zel, Nirnimesh

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable sending of page title in Chrome reports. Page title can leak privacy information hence we don't really want it. BUG=66716 TEST=Sent a report to confirm page title is no longer being sent. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72441

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments incorporated. #

Total comments: 4

Patch Set 3 : Review Changes. #

Patch Set 4 : Mac build fix. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -27 lines)			Patch
M	chrome/browser/bug_report_data.h	View	1 2	3 chunks	+10 lines, -14 lines	0 comments	Download
M	chrome/browser/bug_report_data.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/bug_report_util.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/bug_report_util.cc	View	1 2	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/dom_ui/bug_report_ui.cc	View	1 2	4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bug_report_window_controller.mm	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

zel

http://codereview.chromium.org/6366007/diff/1/chrome/browser/dom_ui/bug_report_ui.cc File chrome/browser/dom_ui/bug_report_ui.cc (right): http://codereview.chromium.org/6366007/diff/1/chrome/browser/dom_ui/bug_report_ui.cc#newcode533 chrome/browser/dom_ui/bug_report_ui.cc:533: target_tab_title_ = string16(); if you don't use target_tab_title_ anymore, ...

9 years, 11 months ago (2011-01-21 21:47:17 UTC) #2

oshima

9 years, 11 months ago (2011-01-21 21:54:21 UTC) #3

rkc

Done and tested. http://codereview.chromium.org/6366007/diff/1/chrome/browser/dom_ui/bug_report_ui.cc File chrome/browser/dom_ui/bug_report_ui.cc (right): http://codereview.chromium.org/6366007/diff/1/chrome/browser/dom_ui/bug_report_ui.cc#newcode533 chrome/browser/dom_ui/bug_report_ui.cc:533: target_tab_title_ = string16(); On 2011/01/21 21:47:17, ...

9 years, 11 months ago (2011-01-22 00:22:13 UTC) #4

oshima

LGTM http://codereview.chromium.org/6366007/diff/6001/chrome/browser/bug_report_data.h File chrome/browser/bug_report_data.h (right): http://codereview.chromium.org/6366007/diff/6001/chrome/browser/bug_report_data.h#newcode50 chrome/browser/bug_report_data.h:50: const std::string& target_tab_url() { return target_tab_url_; } const ...

9 years, 11 months ago (2011-01-23 15:16:24 UTC) #5

rkc

9 years, 11 months ago (2011-01-25 00:00:03 UTC) #6

http://codereview.chromium.org/6366007/diff/6001/chrome/browser/bug_report_da...
File chrome/browser/bug_report_data.h (right):

http://codereview.chromium.org/6366007/diff/6001/chrome/browser/bug_report_da...
chrome/browser/bug_report_data.h:50: const std::string& target_tab_url() {
return target_tab_url_; }
On 2011/01/23 15:16:24, oshima wrote:
> const
> 
> and other accessors.
> 
> while we're at it.

Done.

http://codereview.chromium.org/6366007/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.cc (right):

http://codereview.chromium.org/6366007/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.cc:530: // decide if there never is a reason
to send it at all.
On 2011/01/23 15:16:24, oshima wrote:
> Is this comment still valid?
Removed.
Done.

Expand Messages | Collapse Messages