Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/dom_ui/bug_report_ui.cc

Issue 6366007: Disable sending of page title in Chrome reports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/bug_report_ui.h" 5 #include "chrome/browser/dom_ui/bug_report_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 // Sanity checks. 521 // Sanity checks.
522 if (((index == 0) && (params != "0")) || !browser || 522 if (((index == 0) && (params != "0")) || !browser ||
523 index >= browser->tab_count()) { 523 index >= browser->tab_count()) {
524 return base::StringPiece( 524 return base::StringPiece(
525 ResourceBundle::GetSharedInstance().GetRawDataResource( 525 ResourceBundle::GetSharedInstance().GetRawDataResource(
526 IDR_BUGREPORT_HTML_INVALID)); 526 IDR_BUGREPORT_HTML_INVALID));
527 } 527 }
528 528
529 TabContents* target_tab = browser->GetTabContentsAt(index); 529 TabContents* target_tab = browser->GetTabContentsAt(index);
530 if (target_tab) { 530 if (target_tab) {
531 target_tab_title_ = target_tab->GetTitle(); 531 // TODO(rkc): Remove target tab title completely once we decide if we
532 // decide if there never is a reason to send it at all.
533 target_tab_title_ = string16();
zel 2011/01/21 21:47:17 if you don't use target_tab_title_ anymore, you sh
oshima 2011/01/21 21:54:21 agreed.
rkc 2011/01/22 00:22:13 Done.
rkc 2011/01/22 00:22:13 Done.
532 target_tab_url_ = target_tab->GetURL().spec(); 534 target_tab_url_ = target_tab->GetURL().spec();
533 } 535 }
534 536
535 // Setup the screenshot source after we've verified input is legit. 537 // Setup the screenshot source after we've verified input is legit.
536 SetupScreenshotsSource(); 538 SetupScreenshotsSource();
537 539
538 return base::StringPiece( 540 return base::StringPiece(
539 ResourceBundle::GetSharedInstance().GetRawDataResource( 541 ResourceBundle::GetSharedInstance().GetRawDataResource(
540 IDR_BUGREPORT_HTML)); 542 IDR_BUGREPORT_HTML));
541 } 543 }
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 BugReportUIHTMLSource* html_source = 766 BugReportUIHTMLSource* html_source =
765 new BugReportUIHTMLSource(handler->Init()); 767 new BugReportUIHTMLSource(handler->Init());
766 // Set up the chrome://bugreport/ source. 768 // Set up the chrome://bugreport/ source.
767 BrowserThread::PostTask( 769 BrowserThread::PostTask(
768 BrowserThread::IO, FROM_HERE, 770 BrowserThread::IO, FROM_HERE,
769 NewRunnableMethod( 771 NewRunnableMethod(
770 ChromeURLDataManager::GetInstance(), 772 ChromeURLDataManager::GetInstance(),
771 &ChromeURLDataManager::AddDataSource, 773 &ChromeURLDataManager::AddDataSource,
772 make_scoped_refptr(html_source))); 774 make_scoped_refptr(html_source)));
773 } 775 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698