Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6366002: Begin changing Hydrogen branch instructions. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Begin changing Hydrogen branch instructions. Rename HBranch (the instruction that coerces an arbitrary HValue to control flow) to HTest to free up the term Branch to refer to any control instruction with two successors. Change the virtual FirstSuccessor and SecondSuccessor functions on control instructions to a pair of data members. Committed: http://code.google.com/p/v8/source/detail?r=6417

Patch Set 1 #

Patch Set 2 : Rebase to HEAD> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -133 lines) Patch
M src/hydrogen.cc View 1 11 chunks +35 lines, -42 lines 0 comments Download
M src/hydrogen-instructions.h View 1 9 chunks +48 lines, -59 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +15 lines, -20 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The immediate goal is to get rid of HValue::EmitAtUses and the way we use it ...
9 years, 11 months ago (2011-01-18 12:48:48 UTC) #1
fschneider
9 years, 11 months ago (2011-01-18 14:02:43 UTC) #2
LGTM.

Remember to file an issue porting your changes to the other platforms.

Powered by Google App Engine
This is Rietveld 408576698