Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6362007: [Mac] Organize all tab/tab strip files into chrome/browser/ui/cocoa/tabs/.... (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Organize all tab/tab strip files into chrome/browser/ui/cocoa/tabs/. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71827

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -6088 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/side_tab_strip_controller.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/cocoa/side_tab_strip_controller.mm View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/cocoa/side_tab_strip_view.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/ui/cocoa/side_tab_strip_view.mm View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/cocoa/side_tab_strip_view_unittest.mm View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_controller.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_controller.mm View 1 chunk +0 lines, -306 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_controller_target.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_controller_unittest.mm View 1 chunk +0 lines, -333 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_controller.h View 1 chunk +0 lines, -262 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_controller.mm View 1 chunk +0 lines, -1904 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_controller_unittest.mm View 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_model_observer_bridge.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_model_observer_bridge.mm View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_view.h View 1 chunk +0 lines, -48 lines 0 comments Download
chrome/browser/ui/cocoa/tab_strip_view.mm View 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_strip_view_unittest.mm View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_view.h View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_view.mm View 1 chunk +0 lines, -1056 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_view_unittest.mm View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_window_controller.h View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_window_controller.mm View 1 chunk +0 lines, -356 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/cocoa/tabs/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/side_tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/side_tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/side_tab_strip_view.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/side_tab_strip_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/side_tab_strip_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_controller_target.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_strip_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/cocoa/tabs/tab_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/throbber_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/throbber_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/throbber_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/throbber_view.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/cocoa/throbber_view.mm View 1 chunk +0 lines, -372 lines 0 comments Download
D chrome/browser/ui/cocoa/throbber_view_unittest.mm View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util.mm View 1 chunk +1 line, -1 line 0 comments Download
chrome/chrome_browser.gypi View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
9 years, 11 months ago (2011-01-19 18:57:10 UTC) #1
Avi (use Gerrit)
LG with nits. http://codereview.chromium.org/6362007/diff/1/chrome/browser/automation/automation_provider_mac.mm File chrome/browser/automation/automation_provider_mac.mm (right): http://codereview.chromium.org/6362007/diff/1/chrome/browser/automation/automation_provider_mac.mm#newcode15 chrome/browser/automation/automation_provider_mac.mm:15: #import "chrome/browser/ui/cocoa/browser_window_controller.h" Alphabetize. http://codereview.chromium.org/6362007/diff/1/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm File chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm ...
9 years, 11 months ago (2011-01-19 19:30:23 UTC) #2
Robert Sesek
9 years, 11 months ago (2011-01-19 19:57:32 UTC) #3 
All done. Thanks for the review!

Powered by Google App Engine
This is Rietveld 408576698