Cancel any pending speech recognitions when the dispatcher host terminates.

Cancel any pending speech recognitions when the dispatcher host terminates.

I have not added a new test for this because the existing test is flaky and
didn't seem right to add another flaky test like that. Instead I've added a TODO
to add a browser test for this case once the flaky test has been fixed.

BUG=none
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71956

[bulach, 2011-01-20 14:47:20]

LGTM

one suggestion below. also, I'd suggest changing the title "Cancel all ongoing
recognitions when a renderer terminates." to something like:
"Cancel any pending speech recognitions."

as it's not entirely related to a renderer terminating..

http://codereview.chromium.org/6358007/diff/1/chrome/browser/speech/speech_in...
File chrome/browser/speech/speech_input_browsertest.cc (right):

http://codereview.chromium.org/6358007/diff/1/chrome/browser/speech/speech_in...
chrome/browser/speech/speech_input_browsertest.cc:176: // the a renderer
crashes, we get a call to
s/the //

http://codereview.chromium.org/6358007/diff/3001/chrome/browser/speech/speech...
File chrome/browser/speech/speech_input_dispatcher_host.cc (right):

http://codereview.chromium.org/6358007/diff/3001/chrome/browser/speech/speech...
chrome/browser/speech/speech_input_dispatcher_host.cc:121: if
(received_speech_request_)
suggest: may_have_pending_requests_ ?
it seems slightly better:

if (may_have_pending_requests_)
  manager()->CancelAllRequestsWithDelegate(this);

[Satish, 2011-01-20 15:09:03]

Thanks for the quick review. Addressed both comments, will submit shortly.

http://codereview.chromium.org/6358007/diff/1/chrome/browser/speech/speech_in...
File chrome/browser/speech/speech_input_browsertest.cc (right):

http://codereview.chromium.org/6358007/diff/1/chrome/browser/speech/speech_in...
chrome/browser/speech/speech_input_browsertest.cc:176: // the a renderer
crashes, we get a call to
On 2011/01/20 14:47:20, bulach wrote:
> s/the //

Done.

http://codereview.chromium.org/6358007/diff/3001/chrome/browser/speech/speech...
File chrome/browser/speech/speech_input_dispatcher_host.cc (right):

http://codereview.chromium.org/6358007/diff/3001/chrome/browser/speech/speech...
chrome/browser/speech/speech_input_dispatcher_host.cc:121: if
(received_speech_request_)
On 2011/01/20 14:47:20, bulach wrote:
> suggest: may_have_pending_requests_ ?
> it seems slightly better:
> 
> if (may_have_pending_requests_)
>   manager()->CancelAllRequestsWithDelegate(this);

Done.