Issue 6358001: [Sync] Convert notifications for UNKNOWN to notifications for everything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6358001: [Sync] Convert notifications for UNKNOWN to notifications for everything (Closed)

Created:
9 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Convert notifications for UNKNOWN to notifications for everything Handle this in ChromeInvalidationClient so that we don't have to handle it everywhere else. We were handling it incorrectly anyway, but it wasn't a problem since we always get all updates for all data types. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71507

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Tim's comments #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
M	chrome/browser/sync/notifier/chrome_invalidation_client.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/server_notifier_thread.cc	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM http://codereview.chromium.org/6358001/diff/1/chrome/browser/sync/notifier/server_notifier_thread.cc File chrome/browser/sync/notifier/server_notifier_thread.cc (right): http://codereview.chromium.org/6358001/diff/1/chrome/browser/sync/notifier/server_notifier_thread.cc#newcode69 chrome/browser/sync/notifier/server_notifier_thread.cc:69: DCHECK_NE(model_type, syncable::UNSPECIFIED); I think DCHECK_NE TOP_LEVEL_FOLDER as well ...

9 years, 11 months ago (2011-01-14 22:02:35 UTC) #2

akalin

9 years, 11 months ago (2011-01-14 22:27:53 UTC) #3

On 2011/01/14 22:02:35, timsteele wrote:
> LGTM
> 
>
http://codereview.chromium.org/6358001/diff/1/chrome/browser/sync/notifier/se...
> File chrome/browser/sync/notifier/server_notifier_thread.cc (right):
> 
>
http://codereview.chromium.org/6358001/diff/1/chrome/browser/sync/notifier/se...
> chrome/browser/sync/notifier/server_notifier_thread.cc:69:
DCHECK_NE(model_type,
> syncable::UNSPECIFIED);
> I think DCHECK_NE TOP_LEVEL_FOLDER as well wouldn't hurt.

Changed to check that it's within bounds.

Committing after it compiles locally.

Expand Messages | Collapse Messages