chrome/browser/sync/notifier/server_notifier_thread.cc - Issue 6358001: [Sync] Convert notifications for UNKNOWN to notifications for everything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/notifier/server_notifier_thread.cc

Issue 6358001: [Sync] Convert notifications for UNKNOWN to notifications for everything (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Tim's comments Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/notifier/chrome_invalidation_client.cc ('k') | chrome/browser/sync/tools/sync_listen_notifications.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/notifier/server_notifier_thread.cc

diff --git a/chrome/browser/sync/notifier/server_notifier_thread.cc b/chrome/browser/sync/notifier/server_notifier_thread.cc

index f16587ff97a3863ee0c85de4794d41a156fb9718..0c123c89b56d8fcd93221accb4116fcbcf23109e 100644

--- a/chrome/browser/sync/notifier/server_notifier_thread.cc

+++ b/chrome/browser/sync/notifier/server_notifier_thread.cc

@@ -66,11 +66,9 @@ void ServerNotifierThread::SendNotification(

void ServerNotifierThread::OnInvalidate(syncable::ModelType model_type) {

DCHECK_EQ(MessageLoop::current(), worker_message_loop());

- // TODO(akalin): This is a hack to make new sync data types work

- // with server-issued notifications. Remove this when it's not

- // needed anymore.

- VLOG(1) << "OnInvalidate: " << ((model_type == syncable::UNSPECIFIED) ?

- "UNKNOWN" : syncable::ModelTypeToString(model_type));

+ DCHECK_GE(model_type, syncable::FIRST_REAL_MODEL_TYPE);

+ DCHECK_LT(model_type, syncable::MODEL_TYPE_COUNT);

+ VLOG(1) << "OnInvalidate: " << syncable::ModelTypeToString(model_type);

syncable::ModelTypeBitSet model_types;

model_types[model_type] = true;