Issue 6357011: Stop using browser signin for passphrase migration, just use the normal signi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6357011: Stop using browser signin for passphrase migration, just use the normal signi... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Stop using browser signin for passphrase migration, just use the normal signin flow which is accessible from all parts of the sync UI. Create the correct state transition from login -> initial passphrase selection. BUG=70429 TEST=upgrade a sync-everything profile to latest chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72236

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -42 lines)			Patch
M	chrome/browser/sync/profile_sync_service.h	View	5 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	5 chunks	+14 lines, -34 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

9 years, 11 months ago (2011-01-21 22:46:14 UTC) #2

On 2011/01/21 22:30:12, John Gregg wrote:

LGTM

Expand Messages | Collapse Messages