chrome/browser/prefs/pref_service.h - Issue 6353015: Fix broken PrefService::preference_set() returning not all registered preferences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service.h

Issue 6353015: Fix broken PrefService::preference_set() returning not all registered preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/testing_automation_provider.cc ('K') | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/prefs/pref_service.cc » ('j') | chrome/browser/prefs/pref_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_service.h

diff --git a/chrome/browser/prefs/pref_service.h b/chrome/browser/prefs/pref_service.h

index 24b08d27f93ef346a1e8c0fb0dbe7686d247d0a9..88996e4a35e4c1c1abebc1997a31d20182bc573a 100644

--- a/chrome/browser/prefs/pref_service.h

+++ b/chrome/browser/prefs/pref_service.h

@@ -218,7 +218,9 @@ class PrefService : public base::NonThreadSafe {

}

};

typedef std::set<Preference*, PreferencePathComparator> PreferenceSet;

Mattias Nissler (ping if slow) 2011/01/26 17:55:11 Do these declarations still have to be public then

battre 2011/01/27 09:53:27 Done.

- const PreferenceSet& preference_set() const { return prefs_; }

+ // Stores the effective preference values in |out|.

+ void GetPreferenceValues(DictionaryValue* out) const;

// A helper method to quickly look up a preference. Returns NULL if the

// preference is not registered.