Issue 6350014: Marking NonSearchToSearchDoesntSupportInstant as flaky on Mac/Linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6350014: Marking NonSearchToSearchDoesntSupportInstant as flaky on Mac/Linux.... (Closed)

Created:
9 years, 11 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Marking NonSearchToSearchDoesntSupportInstant as flaky on Mac/Linux. BUG=70810 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72532

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/instant/instant_browsertest.cc	View		1 chunk	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

9 years, 11 months ago (2011-01-25 20:07:33 UTC) #2

LGTM other than the 80char nit.

http://codereview.chromium.org/6350014/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_browsertest.cc (right):

http://codereview.chromium.org/6350014/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_browsertest.cc:501: #define
MAYBE_NonSearchToSearchDoesntSupportInstant
FLAKY_NonSearchToSearchDoesntSupportInstant
80char.  Use \ to break across lines?  Also below.

Expand Messages | Collapse Messages