Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "base/command_line.h" | 5 #include "base/command_line.h" |
| 6 #include "base/stringprintf.h" | 6 #include "base/stringprintf.h" |
| 7 #include "base/utf_string_conversions.h" | 7 #include "base/utf_string_conversions.h" |
| 8 #include "chrome/browser/autocomplete/autocomplete_edit_view.h" | 8 #include "chrome/browser/autocomplete/autocomplete_edit_view.h" |
| 9 #include "chrome/browser/browser_list.h" | 9 #include "chrome/browser/browser_list.h" |
| 10 #include "chrome/browser/browser_window.h" | 10 #include "chrome/browser/browser_window.h" |
| (...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 488 ui_test_utils::WaitForNotification(NotificationType::TAB_CLOSED); | 488 ui_test_utils::WaitForNotification(NotificationType::TAB_CLOSED); |
| 489 EXPECT_FALSE(browser()->instant()->IsShowingInstant()); | 489 EXPECT_FALSE(browser()->instant()->IsShowingInstant()); |
| 490 EXPECT_FALSE(browser()->instant()->is_displayable()); | 490 EXPECT_FALSE(browser()->instant()->is_displayable()); |
| 491 EXPECT_TRUE(browser()->instant()->is_active()); | 491 EXPECT_TRUE(browser()->instant()->is_active()); |
| 492 EXPECT_FALSE(browser()->instant()->IsCurrent()); | 492 EXPECT_FALSE(browser()->instant()->IsCurrent()); |
| 493 } | 493 } |
| 494 | 494 |
| 495 // Verifies transitioning from loading a non-search string to a search string | 495 // Verifies transitioning from loading a non-search string to a search string |
| 496 // with the provider not supporting instant works (meaning we don't display | 496 // with the provider not supporting instant works (meaning we don't display |
| 497 // anything). | 497 // anything). |
| 498 IN_PROC_BROWSER_TEST_F(InstantTest, NonSearchToSearchDoesntSupportInstant) { | 498 #if defined(OS_MACOSX) || defined(OS_LINUX) |
| 499 // Showing as flaky on Mac and linux (chrome os) | |
| 500 // http://crbug.com/70810 | |
| 501 #define MAYBE_NonSearchToSearchDoesntSupportInstant FLAKY_NonSearchToSearchDoesn tSupportInstant | |
|
rohitrao (ping after 24h)
2011/01/25 20:07:33
80char. Use \ to break across lines? Also below.
| |
| 502 #else | |
| 503 #define MAYBE_NonSearchToSearchDoesntSupportInstant NonSearchToSearchDoesntSuppo rtInstant | |
| 504 #endif | |
| 505 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_NonSearchToSearchDoesntSupportInstant) { | |
| 499 ASSERT_TRUE(test_server()->Start()); | 506 ASSERT_TRUE(test_server()->Start()); |
| 500 ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("empty.html")); | 507 ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("empty.html")); |
| 501 GURL url(test_server()->GetURL("files/instant/empty.html")); | 508 GURL url(test_server()->GetURL("files/instant/empty.html")); |
| 502 ASSERT_NO_FATAL_FAILURE(SetLocationBarText(UTF8ToWide(url.spec()))); | 509 ASSERT_NO_FATAL_FAILURE(SetLocationBarText(UTF8ToWide(url.spec()))); |
| 503 // The preview should be active and showing. | 510 // The preview should be active and showing. |
| 504 ASSERT_TRUE(browser()->instant()->is_displayable()); | 511 ASSERT_TRUE(browser()->instant()->is_displayable()); |
| 505 ASSERT_TRUE(browser()->instant()->is_active()); | 512 ASSERT_TRUE(browser()->instant()->is_active()); |
| 506 TabContentsWrapper* initial_tab = browser()->instant()->GetPreviewContents(); | 513 TabContentsWrapper* initial_tab = browser()->instant()->GetPreviewContents(); |
| 507 ASSERT_TRUE(initial_tab); | 514 ASSERT_TRUE(initial_tab); |
| 508 RenderWidgetHostView* rwhv = | 515 RenderWidgetHostView* rwhv = |
| (...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 659 // Check that the preview contents have been committed. | 666 // Check that the preview contents have been committed. |
| 660 ASSERT_FALSE(browser()->instant()->GetPreviewContents()); | 667 ASSERT_FALSE(browser()->instant()->GetPreviewContents()); |
| 661 ASSERT_FALSE(browser()->instant()->is_active()); | 668 ASSERT_FALSE(browser()->instant()->is_active()); |
| 662 TabContents* contents = browser()->GetSelectedTabContents(); | 669 TabContents* contents = browser()->GetSelectedTabContents(); |
| 663 ASSERT_TRUE(contents); | 670 ASSERT_TRUE(contents); |
| 664 | 671 |
| 665 // Check that the value is reflected and onsubmit is called. | 672 // Check that the value is reflected and onsubmit is called. |
| 666 EXPECT_EQ("true 1 0 2 2 a false abcdef true 6 6", | 673 EXPECT_EQ("true 1 0 2 2 a false abcdef true 6 6", |
| 667 GetSearchStateAsString(preview_)); | 674 GetSearchStateAsString(preview_)); |
| 668 } | 675 } |
| OLD | NEW |