net: Add namespace net to Sdch* classes.

net: Add namespace net to Sdch* classes.

BUG=64263
TEST=compiled locally and trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73249

[tfarina, 2011-01-31 02:23:00]

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_filter_unittes...
File net/base/sdch_filter_unittest.cc (right):

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_filter_unittes...
net/base/sdch_filter_unittest.cc:1351: net::SdchManager::Dictionary::PathMatch;
Guys, any glue how to fix this?

See trybot errors, here is the mac output:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/10880/step...

[willchan no longer on Chromium, 2011-01-31 07:02:43]

LGTM

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h
File net/base/sdch_manager.h (right):

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newc...
net/base/sdch_manager.h:171: friend class net::SdchManager;  // Only manager can
construct an instance.
Try removing this net::. The error is because the SdchManager isn't being
friended properly. It looks like compilers are handling this differently. If
`friend class SdchManager` doesn't work, try `friend class ::net::SdchManager`.

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newc...
net/base/sdch_manager.h:180: const base::Time& expiration, const std::set<int>
ports);
Looks like jar wrote an accidental bug here. Should be const std::set<int>&
ports. No need to do the copy by value. Can you fix it here for him? Thanks!

[tfarina, 2011-01-31 12:40:21]

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h
File net/base/sdch_manager.h (right):

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newc...
net/base/sdch_manager.h:171: friend class net::SdchManager;  // Only manager can
construct an instance.
On 2011/01/31 07:02:43, willchan wrote:
> Try removing this net::. The error is because the SdchManager isn't being
> friended properly. It looks like compilers are handling this differently. If
> `friend class SdchManager` doesn't work, try `friend class
::net::SdchManager`.

Done.

http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newc...
net/base/sdch_manager.h:180: const base::Time& expiration, const std::set<int>
ports);
On 2011/01/31 07:02:43, willchan wrote:
> Looks like jar wrote an accidental bug here. Should be const std::set<int>&
> ports. No need to do the copy by value. Can you fix it here for him? Thanks!

Done.

[tfarina, 2011-01-31 13:07:19]

On 2011/01/31 12:40:21, tfarina wrote:
> http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h
> File net/base/sdch_manager.h (right):
> 
>
http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newc...
> net/base/sdch_manager.h:171: friend class net::SdchManager;  // Only manager
can
> construct an instance.
> On 2011/01/31 07:02:43, willchan wrote:
> > Try removing this net::. The error is because the SdchManager isn't being
> > friended properly. It looks like compilers are handling this differently. If
> > `friend class SdchManager` doesn't work, try `friend class
> ::net::SdchManager`.
> 
> Done.
> 

It seems the windows bot is not happy with this CL.

The same error:
1: e:\b\build\slave\win\build\src\net\base\sdch_filter_unittest.cc(1350) : error
C2248: 'net::SdchManager::Dictionary::PathMatch' : cannot access private member
declared in class 'net::SdchManager::Dictionary'

[wtc, 2011-02-02 01:42:03]

LGTM.

http://codereview.chromium.org/6347033/diff/4006/chrome/browser/net/sdch_dict...
File chrome/browser/net/sdch_dictionary_fetcher.h (right):

http://codereview.chromium.org/6347033/diff/4006/chrome/browser/net/sdch_dict...
chrome/browser/net/sdch_dictionary_fetcher.h:20: #include
"net/base/sdch_manager.h"
We may be able to remove this header, now that you moved
the SdchManager::Shutdown() call to the .cc file.