Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 6347033: net: Add namespace net to Sdch* classes. (Closed)

Created:
9 years, 10 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

net: Add namespace net to Sdch* classes. BUG=64263 TEST=compiled locally and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73249

Patch Set 1 : #

Total comments: 5

Patch Set 2 : willchan review #

Patch Set 3 : fixing #

Patch Set 4 : rsleevi help #

Patch Set 5 : namespace net on unittest #

Patch Set 6 : namespace on unittest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -74 lines) Patch
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 chunk +5 lines, -5 lines 1 comment Download
M chrome/browser/net/sdch_dictionary_fetcher.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M net/base/filter.cc View 5 chunks +20 lines, -16 lines 0 comments Download
M net/base/sdch_filter.h View 3 chunks +6 lines, -2 lines 0 comments Download
M net/base/sdch_filter.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M net/base/sdch_filter_unittest.cc View 1 2 3 4 24 chunks +26 lines, -22 lines 0 comments Download
M net/base/sdch_manager.h View 1 2 3 4 5 5 chunks +14 lines, -5 lines 0 comments Download
M net/base/sdch_manager.cc View 1 2 7 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_filter_unittest.cc File net/base/sdch_filter_unittest.cc (right): http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_filter_unittest.cc#newcode1351 net/base/sdch_filter_unittest.cc:1351: net::SdchManager::Dictionary::PathMatch; Guys, any glue how to fix this? See ...
9 years, 10 months ago (2011-01-31 02:23:00 UTC) #1
willchan no longer on Chromium
LGTM http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h File net/base/sdch_manager.h (right): http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newcode171 net/base/sdch_manager.h:171: friend class net::SdchManager; // Only manager can construct ...
9 years, 10 months ago (2011-01-31 07:02:43 UTC) #2
tfarina
http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h File net/base/sdch_manager.h (right): http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newcode171 net/base/sdch_manager.h:171: friend class net::SdchManager; // Only manager can construct an ...
9 years, 10 months ago (2011-01-31 12:40:21 UTC) #3
tfarina
On 2011/01/31 12:40:21, tfarina wrote: > http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h > File net/base/sdch_manager.h (right): > > http://codereview.chromium.org/6347033/diff/4001/net/base/sdch_manager.h#newcode171 > ...
9 years, 10 months ago (2011-01-31 13:07:19 UTC) #4
wtc
9 years, 10 months ago (2011-02-02 01:42:03 UTC) #5
LGTM.

http://codereview.chromium.org/6347033/diff/4006/chrome/browser/net/sdch_dict...
File chrome/browser/net/sdch_dictionary_fetcher.h (right):

http://codereview.chromium.org/6347033/diff/4006/chrome/browser/net/sdch_dict...
chrome/browser/net/sdch_dictionary_fetcher.h:20: #include
"net/base/sdch_manager.h"
We may be able to remove this header, now that you moved
the SdchManager::Shutdown() call to the .cc file.

Powered by Google App Engine
This is Rietveld 408576698