net: Add namespace net to Sdch* classes.

net/base/sdch_manager.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Provides global database of differential decompression dictionaries for the
 // SDCH filter (processes sdch enconded content).
 
 // Exactly one instance of SdchManager is built, and all references are made
 // into that collection.
 //
 // The SdchManager maintains a collection of memory resident dictionaries.  It
@@ skipping 12 matching lines @@
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/gtest_prod_util.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 
+namespace net {
+
 //------------------------------------------------------------------------------
 // Create a public interface to help us load SDCH dictionaries.
 // The SdchManager class allows registration to support this interface.
 // A browser may register a fetcher that is used by the dictionary managers to
 // get data from a specified URL.  This allows us to use very high level browser
 // functionality in this base (when the functionaity can be provided).
 class SdchFetcher {
  public:
   SdchFetcher() {}
   virtual ~SdchFetcher() {}
 
   // The Schedule() method is called when there is a need to get a dictionary
   // from a server.  The callee is responsible for getting that dictionary_text,
   // and then calling back to AddSdchDictionary() to the SdchManager instance.
   virtual void Schedule(const GURL& dictionary_url) = 0;
  private:
   DISALLOW_COPY_AND_ASSIGN(SdchFetcher);
 };
+
 //------------------------------------------------------------------------------
 
 class SdchManager {
  public:
   // A list of errors that appeared and were either resolved, or used to turn
   // off sdch encoding.
   enum ProblemCodes {
     MIN_PROBLEM_CODE,
 
     // Content-encoding correction problems.
@@ skipping 96 matching lines @@
 
   // There is one instance of |Dictionary| for each memory-cached SDCH
   // dictionary.
   class Dictionary : public base::RefCounted<Dictionary> {
    public:
     // Sdch filters can get our text to use in decoding compressed data.
     const std::string& text() const { return text_; }
 
    private:
     friend class base::RefCounted<Dictionary>;
-    friend class SdchManager;  // Only manager can construct an instance.
+    friend class net::SdchManager;  // Only manager can construct an instance.

[willchan no longer on Chromium, 2011/01/31 07:02:43]

Try removing this net::. The error is because the SdchManager isn't being
friended properly. It looks like compilers are handling this differently. If
`friend class SdchManager` doesn't work, try `friend class ::net::SdchManager`.

[tfarina, 2011/01/31 12:40:21]

Done.

     FRIEND_TEST_ALL_PREFIXES(SdchFilterTest, PathMatch);
 
     // Construct a vc-diff usable dictionary from the dictionary_text starting
     // at the given offset.  The supplied client_hash should be used to
     // advertise the dictionary's availability relative to the suppplied URL.
     Dictionary(const std::string& dictionary_text, size_t offset,
                const std::string& client_hash, const GURL& url,
                const std::string& domain, const std::string& path,
                const base::Time& expiration, const std::set<int> ports);

[willchan no longer on Chromium, 2011/01/31 07:02:43]

Looks like jar wrote an accidental bug here. Should be const std::set<int>&
ports. No need to do the copy by value. Can you fix it here for him? Thanks!

[tfarina, 2011/01/31 12:40:21]

Done.

     ~Dictionary();
 
     const GURL& url() const { return url_; }
     const std::string& client_hash() const { return client_hash_; }
 
     // Security method to check if we can advertise this dictionary for use
     // if the |target_url| returns SDCH compressed data.
     bool CanAdvertise(const GURL& target_url);
 
     // Security methods to check if we can establish a new dictionary with the
@@ skipping 170 matching lines @@
   // blacklisting expires.
   DomainCounter exponential_blacklist_count;
 
   // List of hostnames for which a latency experiment is allowed (because a
   // round trip test has recently passed).
   ExperimentSet allow_latency_experiment_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };
 
+}  // namespace net
+
 #endif  // NET_BASE_SDCH_MANAGER_H_