ARM: Initial type recording binary operation stub...

ARM: Initial type recording binary operation stub

This implements the type recording binary operation stub for ARM. This first iteration only supports ADD. Handling of 32-bit integers is currently not implemented but just transitions. The generic case for now delegates to the generic binary operation stub.

Committed: http://code.google.com/p/v8/source/detail?r=6471

[Mads Ager (chromium), 2011-01-25 14:23:17]

LGTM

http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2505: __ PrepareCallCFunction(4, scratch1);  // Two
doubles count as 4 arguments.
Long line.

[Mads Ager (chromium), 2011-01-25 14:25:09]

http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h#n...
src/arm/macro-assembler-arm.h:744: void JumpIfSmi(Register reg, Label* on_smi);
Don't we have BranchOnSmi? Either use that one or get rid of it?

[Søren Thygesen Gjesse, 2011-01-25 14:49:40]

http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2505: __ PrepareCallCFunction(4, scratch1);  // Two
doubles count as 4 arguments.
On 2011/01/25 14:23:17, Mads Ager wrote:
> Long line.

Done.

http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h#n...
src/arm/macro-assembler-arm.h:744: void JumpIfSmi(Register reg, Label* on_smi);
On 2011/01/25 14:25:09, Mads Ager wrote:
> Don't we have BranchOnSmi? Either use that one or get rid of it?

You are right - changed to use BranchOnSmi. There is a mixture of BranchOn* and
JumpIf* in the ARM macro assembler.